Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1942233002: [API] remove (deprecated) hidden properties. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
CC:
Hannes Payer (out of office), Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[API] remove (deprecated) hidden properties. v8::Object::{Set,Get,Delete}HiddenValue have long been deprecated. Please use v8::Object::{Set,Has,Get}Private instead. R=jochen@chromium.org LOG=Y Committed: https://crrev.com/6df9379cb0e3400b5d50d582d3cb10d8a65d7757 Cr-Commit-Position: refs/heads/master@{#35977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -283 lines) Patch
M include/v8.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -39 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -156 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Yang
4 years, 7 months ago (2016-05-03 10:49:32 UTC) #1
jochen (gone - plz use gerrit)
please add a sentence to the CL description that advises embedders that use this API ...
4 years, 7 months ago (2016-05-03 10:50:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942233002/1
4 years, 7 months ago (2016-05-03 10:59:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 11:47:52 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 11:48:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6df9379cb0e3400b5d50d582d3cb10d8a65d7757
Cr-Commit-Position: refs/heads/master@{#35977}

Powered by Google App Engine
This is Rietveld 408576698