Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1942223002: Re-enable complex text path on android (Closed)

Created:
4 years, 7 months ago by eae
Modified:
4 years, 7 months ago
Reviewers:
drott
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable complex text path on android Trying to re-enable the complex text path on Android now that hb-ot-font is used for glyph lookups and the separate glyph cache has been removed. This should result in lower memory usage for the complex text code path, we'll watch the memory bots though and revert as needed if it regresses. BUG=577306 R=drott@chromium.org Committed: https://crrev.com/7e9bf5e20a53b0934944d5d40456ec7e7ea0815b Cr-Commit-Position: refs/heads/master@{#391215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
eae
4 years, 7 months ago (2016-05-03 13:07:01 UTC) #3
drott
LGTM
4 years, 7 months ago (2016-05-03 13:10:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942223002/1
4 years, 7 months ago (2016-05-03 13:12:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 13:15:51 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7e9bf5e20a53b0934944d5d40456ec7e7ea0815b Cr-Commit-Position: refs/heads/master@{#391215}
4 years, 7 months ago (2016-05-03 13:17:05 UTC) #10
eae
4 years, 7 months ago (2016-05-04 07:45:28 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1949963002/ by eae@chromium.org.

The reason for reverting is: Caused a 5-7% memory regression..

Powered by Google App Engine
This is Rietveld 408576698