Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1942163002: Remove some dead code in src/objects.cc (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove some dead code in src/objects.cc R=bmeurer@chromium.org Committed: https://crrev.com/c135ab426434b6775915bc2f824b5d4ac6b366f6 Cr-Commit-Position: refs/heads/master@{#35960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -124 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/objects.h View 3 chunks +0 lines, -13 lines 0 comments Download
M src/objects.cc View 3 chunks +0 lines, -57 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 7 months ago (2016-05-03 05:24:11 UTC) #1
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-03 05:26:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942163002/1
4 years, 7 months ago (2016-05-03 05:26:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 05:55:16 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 05:57:04 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c135ab426434b6775915bc2f824b5d4ac6b366f6
Cr-Commit-Position: refs/heads/master@{#35960}

Powered by Google App Engine
This is Rietveld 408576698