Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1942153002: [turbofan] Hook up the shift code stubs with TurboFan. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Hook up the shift code stubs with TurboFan. Use the ShiftLeftStub, ShiftRightStub and ShiftRightLogicalStub in JSGenericLowering instead of the old-style patching BinaryOpIC. Also remove the machinery to support patching ICs in TurboFan completely, as this was the last user of code patching in TurboFan! R=yangguo@chromium.org Committed: https://crrev.com/577ec180fba50d718dae1b4f6817fb88cd819c0e Cr-Commit-Position: refs/heads/master@{#35959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -70 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +8 lines, -11 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-03 05:00:40 UTC) #1
Benedikt Meurer
Hey Yang, Code patching must die! Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-03 05:01:20 UTC) #2
Yang
On 2016/05/03 05:01:20, Benedikt Meurer wrote: > Hey Yang, > > Code patching must die! ...
4 years, 7 months ago (2016-05-03 05:01:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942153002/1
4 years, 7 months ago (2016-05-03 05:01:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 05:32:41 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 05:33:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/577ec180fba50d718dae1b4f6817fb88cd819c0e
Cr-Commit-Position: refs/heads/master@{#35959}

Powered by Google App Engine
This is Rietveld 408576698