Chromium Code Reviews Chromium Code Reviews
Issue 1942143002:
swarming: isolate defaults (Closed)
Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@swarming-ns-re| Index: appengine/swarming/handlers_endpoints.py |
| diff --git a/appengine/swarming/handlers_endpoints.py b/appengine/swarming/handlers_endpoints.py |
| index f130e3109fd392e0881bdc5fbd9a2b08670ea99c..394bc408ecafa278c9c6a3213c7e8ab222bf4dd8 100644 |
| --- a/appengine/swarming/handlers_endpoints.py |
| +++ b/appengine/swarming/handlers_endpoints.py |
| @@ -267,6 +267,22 @@ class SwarmingTasksService(remote.Service): |
| in the task request. |
| """ |
| logging.info('%s', request) |
| + |
| + if request.properties is None: |
|
M-A Ruel
2016/05/12 13:48:25
in general we use the short form:
if not request.
nodir
2016/05/12 22:00:09
Done.
|
| + raise endpoints.BadRequestException('properties are required') |
| + |
| + # Apply isolate defaults. |
| + cfg = config.settings() |
| + if cfg.isolate.default_server and cfg.isolate.default_namespace: |
| + request.properties.inputs_ref = ( |
| + request.properties.inputs_ref or swarming_rpcs.FilesRef()) |
| + request.properties.inputs_ref.isolatedserver = ( |
| + request.properties.inputs_ref.isolatedserver or |
| + cfg.isolate.default_server) |
| + request.properties.inputs_ref.namespace = ( |
| + request.properties.inputs_ref.namespace or |
| + cfg.isolate.default_namespace) |
| + |
| try: |
| request = message_conversion.new_task_request_from_rpc( |
| request, utils.utcnow()) |
