swarming: isolate defaults

appengine/swarming/server/config.py

 # Copyright 2013 The LUCI Authors. All rights reserved.
 # Use of this source code is governed by the Apache v2.0 license that can be
 # found in the LICENSE file.
 
 """Instance specific settings."""
 
 import logging
 import posixpath
 
 from components import config
 from components import gitiles
 from components import net
 from components import utils
 from components.config import validation
 
 from proto import config_pb2
+from server import task_request
+
 
 SETTINGS_CFG_FILENAME = 'settings.cfg'
+SECONDS_IN_YEAR = 60 * 60 * 24 * 365
 
 
 ConfigApi = config.ConfigApi
 
 
+def validate_isolate_settings(cfg, ctx):
+  if bool(cfg.default_server) != bool(cfg.default_namespace):
+    ctx.error(
+        'either specify both default_server and default_namespace or none')
+  elif cfg.default_server:
+    if not cfg.default_server.startswith(('https://', 'http://')):
+      ctx.error('default_server must start with "https://" or "http://"')
+
+    if not task_request.NAMESPACE_RE.match(cfg.default_namespace):
+      ctx.error('invalid namespace "%s"', cfg.default_namespace)
+
+
 @validation.self_rule(SETTINGS_CFG_FILENAME, config_pb2.SettingsCfg)
 def validate_settings(cfg, ctx):
   """Validates settings.cfg file against proto message schema."""
   def within_year(value):
     if value < 0:
       ctx.error('cannot be negative')
-    elif value > 60 * 60 * 24 * 365:
+    elif value > SECONDS_IN_YEAR:
       ctx.error('cannot be more than a year')
 
   with ctx.prefix('bot_death_timeout_secs '):
     within_year(cfg.bot_death_timeout_secs)
   with ctx.prefix('reusable_task_age_secs '):
     within_year(cfg.reusable_task_age_secs)
 
+  if cfg.HasField('isolate'):
+    with ctx.prefix('isolate: '):
+      validate_isolate_settings(cfg.isolate, ctx)
+
 
 @utils.memcache('config:get_configs_url', time=60)
 def _get_configs_url():
   """Returns URL where luci-config fetches configs from."""
   url = None
   try:
     url = config.get_config_set_location(config.self_config_set())
   except net.Error:
     logging.info(
         'Could not get configs URL. Possibly config directory for this '
@@ skipping 55 matching lines @@
     'config_service_url': (
         'https://%s' % cfg_service_hostname if cfg_service_hostname else ''
     ),
   }
 
 
 @utils.cache_with_expiration(60)
 def settings():
   """Loads settings from an NDB-based cache or a default one if not present."""
   return _get_settings()[1]