Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1942133002: Closure compilation: rewrite doc now that there's try bots (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, Theresa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Closure compilation: rewrite doc now that there's try bots * De-emphasize local instructions * Remove some instructions that are probably bitrotten at this point :( R=groby@chromium.org BUG=468366 NOTRY=true Committed: https://crrev.com/b0b126710575e302541eb44c7a5d0c4c1000ffa5 Cr-Commit-Position: refs/heads/master@{#391362}

Patch Set 1 #

Total comments: 14

Patch Set 2 : groby #

Patch Set 3 : change order of try and continous integration systems #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -211 lines) Patch
M docs/closure_compilation.md View 1 2 3 chunks +110 lines, -211 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Dan Beam
4 years, 7 months ago (2016-05-03 04:15:04 UTC) #2
groby-ooo-7-16
Thank you for updating this. LGTM with a few nitpicky nits. https://codereview.chromium.org/1942133002/diff/1/docs/closure_compilation.md File docs/closure_compilation.md (right): ...
4 years, 7 months ago (2016-05-03 05:51:15 UTC) #3
Dan Beam
https://codereview.chromium.org/1942133002/diff/1/docs/closure_compilation.md File docs/closure_compilation.md (right): https://codereview.chromium.org/1942133002/diff/1/docs/closure_compilation.md#newcode5 docs/closure_compilation.md:5: [Strongly-typed languages](https://en.wikipedia.org/wiki/Strong_and_weak_typing) On 2016/05/03 05:51:15, groby wrote: > Completely ...
4 years, 7 months ago (2016-05-03 21:24:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942133002/40001
4 years, 7 months ago (2016-05-03 21:27:52 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-03 21:33:31 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 21:35:35 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b0b126710575e302541eb44c7a5d0c4c1000ffa5
Cr-Commit-Position: refs/heads/master@{#391362}

Powered by Google App Engine
This is Rietveld 408576698