Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc

Issue 1942123002: Plumb decoded video pixel format from GPU process to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
diff --git a/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc b/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
index 43545e7390f1de2f9d4f076bcc42a468841c8685..e280602fc453768f6e4b10b9ac5b184f285ffc28 100644
--- a/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
+++ b/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
@@ -178,6 +178,10 @@ void GpuVideoDecodeAcceleratorHost::Destroy() {
delete this;
}
+VideoPixelFormat GpuVideoDecodeAcceleratorHost::GetOutputFormat() const {
+ return picture_buffer_format_;
miu 2016/05/12 20:03:02 Order-of-operations consideration: Should we DCHEC
+}
+
void GpuVideoDecodeAcceleratorHost::OnWillDeleteImpl() {
DCHECK(CalledOnValidThread());
impl_ = NULL;
@@ -217,12 +221,14 @@ void GpuVideoDecodeAcceleratorHost::OnBitstreamBufferProcessed(
}
void GpuVideoDecodeAcceleratorHost::OnProvidePictureBuffer(
+ VideoPixelFormat format,
uint32_t num_requested_buffers,
uint32_t textures_per_buffer,
const gfx::Size& dimensions,
uint32_t texture_target) {
DCHECK(CalledOnValidThread());
miu 2016/05/12 20:03:02 Robustness consideration: Should we DCHECK() that
picture_buffer_dimensions_ = dimensions;
+ picture_buffer_format_ = format;
const int kMaxVideoPlanes = 4;
if (textures_per_buffer > kMaxVideoPlanes) {

Powered by Google App Engine
This is Rietveld 408576698