Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 1942073002: [DevTools] Move getCompletions to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
index bba2c6e5f6d1dfe3da730ee0fc25a806ba2bb48f..21a6b04554ea045d0140bebdc50784663908e8e2 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
@@ -259,6 +259,14 @@ WebInspector.RemoteObject.prototype = {
},
/**
+ * @return {!Promise<!Array<string>>}
+ */
+ getCompletionsPromise: function()
pfeldman 2016/05/03 18:07:25 completionsPromise
+ {
+ throw "Not implemented";
+ },
+
+ /**
* @return {!WebInspector.Target}
*/
target: function()
@@ -883,6 +891,27 @@ WebInspector.RemoteObjectImpl.prototype = {
this._runtimeAgent.callFunctionOn(this._objectId, functionDeclaration.toString(), args, true, true, false, undefined, mycallback);
},
+ /**
+ * @override
+ * @return {!Promise<!Array<string>>}
+ */
+ getCompletionsPromise: function()
+ {
+ var callback;
+ var promise = new Promise(fulfill => callback = fulfill);
+ this._runtimeAgent.getCompletions(this._objectId, this.type, didGetCompletions);
+ return promise;
+
+ /**
+ * @param {?Protocol.Error} error
+ * @param {!Array<string>} completions
+ */
+ function didGetCompletions(error, completions)
+ {
+ callback(error ? [] : completions);
+ }
+ },
+
release: function()
{
if (!this._objectId)

Powered by Google App Engine
This is Rietveld 408576698