Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1942063002: Makes BitmapUploader early out if error encountered (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes BitmapUploader early out if error encountered This avoids a CHECK in trying to use gl functions. BUG=594600 TEST=none R=fsamuel@chromium.org Committed: https://crrev.com/8376db0747208ba10bdc333c0262a025cd792ee6 Cr-Commit-Position: refs/heads/master@{#391292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 7 months ago (2016-05-02 23:46:51 UTC) #1
Fady Samuel
lgtm
4 years, 7 months ago (2016-05-03 16:51:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1942063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1942063002/1
4 years, 7 months ago (2016-05-03 16:52:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 18:00:57 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:02:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8376db0747208ba10bdc333c0262a025cd792ee6
Cr-Commit-Position: refs/heads/master@{#391292}

Powered by Google App Engine
This is Rietveld 408576698