chrome/app_shim/chrome_main_app_mode_mac.mm - Issue 1942053002: Deletes base::MessageLoop::set_thread_name().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app_shim/chrome_main_app_mode_mac.mm

Issue 1942053002: Deletes base::MessageLoop::set_thread_name(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: uses PlatformThread::GetName Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app_shim/chrome_main_app_mode_mac.mm

diff --git a/chrome/app_shim/chrome_main_app_mode_mac.mm b/chrome/app_shim/chrome_main_app_mode_mac.mm

index 37d21a873c424d3dd30d67a7a782198e621b864a..20b125825da9d4b4203e9a0770d021c26fa0837f 100644

--- a/chrome/app_shim/chrome_main_app_mode_mac.mm

+++ b/chrome/app_shim/chrome_main_app_mode_mac.mm

@@ -647,7 +647,6 @@ int ChromeAppModeStart_v4(const app_mode::ChromeAppModeInfo* info) {

AppShimController controller;

base::MessageLoopForUI main_message_loop;

- main_message_loop.set_thread_name("MainThread");

base::PlatformThread::SetName("CrAppShimMain");

// In tests, launching Chrome does nothing, and we won't get a ping response,