Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 194203002: [webcrypto] Remove support for SHA-224 (CL 2 or 3). (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Remove support for SHA-224 (CL 2 or 3). Chromium side of the change. This was removed by the spec: https://dvcs.w3.org/hg/webcrypto-api/rev/3f7df730b2c7 BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -36 lines) Patch
M content/child/webcrypto/platform_crypto_nss.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M content/child/webcrypto/platform_crypto_openssl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/webcrypto/shared_crypto.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/webcrypto/webcrypto_util.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/test/data/webcrypto/digest.json View 3 chunks +1 line, -13 lines 0 comments Download
M content/test/data/webcrypto/hmac.json View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eroman
6 years, 9 months ago (2014-03-11 03:35:41 UTC) #1
Ryan Sleevi
delete ALL the SHAs! Er, wait, just delete this one. LGTM
6 years, 9 months ago (2014-03-11 03:40:27 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-11 22:48:13 UTC) #3
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 9 months ago (2014-03-11 22:48:18 UTC) #4
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-12 23:06:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/194203002/1
6 years, 9 months ago (2014-03-12 23:08:41 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 05:46:23 UTC) #7
Message was sent while issue was closed.
Change committed as 256764

Powered by Google App Engine
This is Rietveld 408576698