third_party/WebKit/Source/core/frame/Deprecation.cpp - Issue 1942003002: Fix geolocation removal from insecure contexts console message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1942003002: Fix geolocation removal from insecure contexts console message (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/Deprecation.cpp

diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp

index 8bb12b520ce7ecf05683b7470b138fe258ad0dea..d9929a22cd27fee327bb16875df7534e9cd6765e 100644

--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp

+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp

@@ -296,7 +296,7 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)

// is fixed so geolocation can be removed there. After that, this

// should be updated to read similarly to GetUserMediaInsecureOrigin's

Rick Byers 2016/05/02 21:43:40 Is this TODO still relevant? I.e. does geolocatio

jww 2016/05/02 21:59:12 Arg, I totally blanked on that case, and that's wh

// message.

- return "getCurrentPosition() and watchPosition() are deprecated on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

+ return "getCurrentPosition() and watchPosition() no longer work on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

case UseCounter::GetUserMediaInsecureOrigin:

case UseCounter::GetUserMediaInsecureOriginIframe: