Fix origin trials test private key

Fix origin trials test private key

BUG=608462
R=mek@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/e6ed3b933c4e023e27bf30d6bfff870b9ac41a86

[iclelland, 2016-05-02 20:31:10]

Description was changed from

==========
Fix origin trials test private key

BUG=608462
==========

to

==========
Fix origin trials test private key

BUG=608462
==========

[iclelland, 2016-05-02 20:31:10]

iclelland@chromium.org changed reviewers:
+ mek@chromium.org

[iclelland, 2016-05-02 20:35:12]

mek -- I'm not certain what to do with this one; codereview seems to mangle the
patch because of the binary file. (See
https://bugs.chromium.org/p/chromium/issues/detail?id=557512 for the original
report)

When I previously committed this file, the result in git was only 12 bytes long
-- I suspect as a result of Rietveld doing some misguided utf8 encoding on it.
It will probably do it again if I check the commit box on
codereview.chromium.org.

I'm guessing that the only way I'll be able to commit this is from my command
line, and in addition, you won't be able to actually review the file beforehand.
Should I just TBR you and commit the patch?

[Marijn Kruisselbrink, 2016-05-02 20:47:15]

On 2016/05/02 at 20:35:12, iclelland wrote:
> mek -- I'm not certain what to do with this one; codereview seems to mangle
the patch because of the binary file. (See
https://bugs.chromium.org/p/chromium/issues/detail?id=557512 for the original
report)
> 
> When I previously committed this file, the result in git was only 12 bytes
long -- I suspect as a result of Rietveld doing some misguided utf8 encoding on
it. It will probably do it again if I check the commit box on
codereview.chromium.org.
> 
> I'm guessing that the only way I'll be able to commit this is from my command
line, and in addition, you won't be able to actually review the file beforehand.
Should I just TBR you and commit the patch?

Possibly adding a tools/origin_trials/.gitattributes files with "eftest.key
binary" (or even "*.key binary") might help. For some reason git seems to treat
the file as text rather than binary (which also might explain why it replaces \r
(0x0D) with \n (0x0A). Not sure if with that fixed committing through the CQ
will work, but committing using `git cl land` does not mean that you'll need to
TBR it, as it will still take my lgtm on this review into account (even if what
you land isn't exactly what's on rietveld).

[iclelland, 2016-05-03 11:25:26]

On 2016/05/02 20:47:15, Marijn Kruisselbrink wrote:
> On 2016/05/02 at 20:35:12, iclelland wrote:
> > mek -- I'm not certain what to do with this one; codereview seems to mangle
> the patch because of the binary file. (See
> https://bugs.chromium.org/p/chromium/issues/detail?id=557512 for the original
> report)
> > 
> > When I previously committed this file, the result in git was only 12 bytes
> long -- I suspect as a result of Rietveld doing some misguided utf8 encoding
on
> it. It will probably do it again if I check the commit box on
> http://codereview.chromium.org.
> > 
> > I'm guessing that the only way I'll be able to commit this is from my
command
> line, and in addition, you won't be able to actually review the file
beforehand.
> Should I just TBR you and commit the patch?
> 
> Possibly adding a tools/origin_trials/.gitattributes files with "eftest.key
> binary" (or even "*.key binary") might help. For some reason git seems to
treat
> the file as text rather than binary (which also might explain why it replaces
\r
> (0x0D) with \n (0x0A). Not sure if with that fixed committing through the CQ
> will work, but committing using `git cl land` does not mean that you'll need
to
> TBR it, as it will still take my lgtm on this review into account (even if
what
> you land isn't exactly what's on rietveld).

Gitattributes is a great idea -- I'd not thought about that file in a long time
:) Whether or not it fixes it in rietveld, it certainly makes the repository
happier:

    tools/origin_trials/.gitattributes |   1 +
    tools/origin_trials/eftest.key     | Bin 12 -> 64 bytes
    2 files changed, 1 insertion(+)

Was your l g t m in the last comment deliberate? It seemed offhand, so I don't
want to land without double-checking.

Thanks

[Marijn Kruisselbrink, 2016-05-03 18:39:54]

On 2016/05/03 at 11:25:26, iclelland wrote:
> Was your l g t m in the last comment deliberate? It seemed offhand, so I don't
want to land without double-checking.

Sorry for being confusing. Definitely lgtm.

[commit-bot: I haz the power, 2016-05-04 02:33:15]

Description was changed from

==========
Fix origin trials test private key

BUG=608462
==========

to

==========
Fix origin trials test private key

BUG=608462
R=mek@chromium.org

Committed: https://crrev.com/e6ed3b933c4e023e27bf30d6bfff870b9ac41a86
Cr-Commit-Position: refs/heads/master@{#391425}
==========

[commit-bot: I haz the power, 2016-05-04 02:33:16]

Patchset 2 (id:??) landed as
https://crrev.com/e6ed3b933c4e023e27bf30d6bfff870b9ac41a86
Cr-Commit-Position: refs/heads/master@{#391425}

[iclelland, 2016-05-04 02:34:05]

Description was changed from

==========
Fix origin trials test private key

BUG=608462
R=mek@chromium.org

Committed: https://crrev.com/e6ed3b933c4e023e27bf30d6bfff870b9ac41a86
Cr-Commit-Position: refs/heads/master@{#391425}
==========

to

==========
Fix origin trials test private key

BUG=608462
R=mek@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/e6ed3b933c4e023e27bf30d6bfff...
==========

[iclelland, 2016-05-04 02:34:06]

Committed patchset #2 (id:20001) manually as
e6ed3b933c4e023e27bf30d6bfff870b9ac41a86 (presubmit successful).