device/bluetooth/bluetooth_device_win.cc - Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_device_win.cc

Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Use enum and change to EXPECT_EQ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/proximity_auth/proximity_monitor_impl_unittest.cc ('K') | « device/bluetooth/bluetooth_device_win.h ('k') | device/bluetooth/bluetooth_low_energy_device_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_device_win.cc

diff --git a/device/bluetooth/bluetooth_device_win.cc b/device/bluetooth/bluetooth_device_win.cc

index 525ab0a1d9da8f5e2aa24adcabc9d13e46845e1d..9434b8a564e52937cf4b5baee0c72f5d247071e3 100644

--- a/device/bluetooth/bluetooth_device_win.cc

+++ b/device/bluetooth/bluetooth_device_win.cc

@@ -112,13 +112,13 @@ BluetoothDevice::UUIDList BluetoothDeviceWin::GetUUIDs() const {

return uuids_;

}

-int16_t BluetoothDeviceWin::GetInquiryRSSI() const {

- return kUnknownPower;

+int8_t BluetoothDeviceWin::GetInquiryRSSI() const {

+ return kUnknownRSSI;

}

-int16_t BluetoothDeviceWin::GetInquiryTxPower() const {

+int8_t BluetoothDeviceWin::GetInquiryTxPower() const {

NOTIMPLEMENTED();

- return kUnknownPower;

+ return kUnknownTxPower;

}

bool BluetoothDeviceWin::ExpectingPinCode() const {