device/bluetooth/bluetooth_device_android.cc - Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_device_android.cc

Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Use enum and change to EXPECT_EQ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/proximity_auth/proximity_monitor_impl_unittest.cc ('K') | « device/bluetooth/bluetooth_device_android.h ('k') | device/bluetooth/bluetooth_device_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_device_android.cc

diff --git a/device/bluetooth/bluetooth_device_android.cc b/device/bluetooth/bluetooth_device_android.cc

index 8e5b2ec261b06a9fd32393c37fa0a5df47327094..256cebd21ade7c91d54a710e7f90ce404051138e 100644

--- a/device/bluetooth/bluetooth_device_android.cc

+++ b/device/bluetooth/bluetooth_device_android.cc

@@ -140,14 +140,14 @@ BluetoothDevice::UUIDList BluetoothDeviceAndroid::GetUUIDs() const {

return uuids;

}

-int16_t BluetoothDeviceAndroid::GetInquiryRSSI() const {

+int8_t BluetoothDeviceAndroid::GetInquiryRSSI() const {

NOTIMPLEMENTED();

- return kUnknownPower;

+ return kUnknownRSSI;

}

-int16_t BluetoothDeviceAndroid::GetInquiryTxPower() const {

+int8_t BluetoothDeviceAndroid::GetInquiryTxPower() const {

NOTIMPLEMENTED();

- return kUnknownPower;

+ return kUnknownTxPower;

}

bool BluetoothDeviceAndroid::ExpectingPinCode() const {