device/bluetooth/bluetooth_device.cc - Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_device.cc

Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Use enum and change to EXPECT_EQ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/proximity_auth/proximity_monitor_impl_unittest.cc ('K') | « device/bluetooth/bluetooth_device.h ('k') | device/bluetooth/bluetooth_device_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_device.cc

diff --git a/device/bluetooth/bluetooth_device.cc b/device/bluetooth/bluetooth_device.cc

index 7d37591f5ea21483e15af7ab315436d3e8a6e70e..a397127fef47ca3219e8136ed5f2d99aae441630 100644

--- a/device/bluetooth/bluetooth_device.cc

+++ b/device/bluetooth/bluetooth_device.cc

@@ -30,12 +30,13 @@ BluetoothDevice::~BluetoothDevice() {

}

BluetoothDevice::ConnectionInfo::ConnectionInfo()

- : rssi(kUnknownPower),

- transmit_power(kUnknownPower),

- max_transmit_power(kUnknownPower) {}

+ : rssi(kUnknownRSSI),

+ transmit_power(kUnknownTxPower),

+ max_transmit_power(kUnknownTxPower) {}

-BluetoothDevice::ConnectionInfo::ConnectionInfo(

- int rssi, int transmit_power, int max_transmit_power)

+BluetoothDevice::ConnectionInfo::ConnectionInfo(int8_t rssi,

+ int8_t transmit_power,

+ int8_t max_transmit_power)

: rssi(rssi),

transmit_power(transmit_power),

max_transmit_power(max_transmit_power) {}