content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc - Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc

Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Moar fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/bluetooth/bluetooth_device.cc ('k') | device/bluetooth/bluetooth_classic_device_mac.h » ('j') | device/bluetooth/bluetooth_device.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc

diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc

index 3bbf1692ca919e55c2c4a05ada02c5c72ab54e0c..76e463dbd20559bfd0505b192536ad772390f74f 100644

--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc

+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc

@@ -340,11 +340,9 @@ scoped_refptr<NiceMockBluetoothAdapter>

LayoutTestBluetoothAdapterProvider::GetPowerPresenceAdapter(

bool tx_power_present,

bool rssi_present) {

- // TODO(ortuno): RSSI Unknown and Tx Power Unknown should have different

- // values. Add kUnknownTxPower when implemented: http://crbug.com/551572

int tx_power =

- tx_power_present ? kDefaultTxPower : BluetoothDevice::kUnknownPower;

- int rssi = rssi_present ? kDefaultRssi : BluetoothDevice::kUnknownPower;

+ tx_power_present ? kDefaultTxPower : BluetoothDevice::kUnknownTxPower;

+ int rssi = rssi_present ? kDefaultRssi : BluetoothDevice::kUnknownRSSI;

return GetPowerValueAdapter(tx_power, rssi);

}

« no previous file with comments | « content/common/bluetooth/bluetooth_device.cc ('k') | device/bluetooth/bluetooth_classic_device_mac.h » ('j') | device/bluetooth/bluetooth_device.h » ('J')