Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/advertising-data.html

Issue 1941923002: bluetooth: Return int8_t and use -128 for unknown tx power. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: Moar fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« device/bluetooth/dbus/bluetooth_device_client.cc ('K') | « extensions/browser/api/bluetooth/bluetooth_api_utils.cc ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.cpp » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <script src="../resources/testharness.js"></script> 2 <script src="../resources/testharness.js"></script>
3 <script src="../resources/testharnessreport.js"></script> 3 <script src="../resources/testharnessreport.js"></script>
4 <script src="../resources/bluetooth/bluetooth-helpers.js"></script> 4 <script src="../resources/bluetooth/bluetooth-helpers.js"></script>
5 <script> 5 <script>
6 'use strict'; 6 'use strict';
7 7
8 test(t => { assert_true(window.testRunner instanceof Object); t.done(); }, 8 test(t => { assert_true(window.testRunner instanceof Object); t.done(); },
9 'window.testRunner is required for the following tests.'); 9 'window.testRunner is required for the following tests.');
10 // Tests that we are handling values returned from the underlying platform 10 // Tests that we are handling values returned from the underlying platform
11 // correctly. Only meant to be used by chromium. 11 // correctly. Only meant to be used by chromium.
12 [{ 12 [{
13 name: 'Tx Power too low must result in nulled txPower.', 13 name: 'Tx Power too low must result in nulled txPower.',
14 tx_power: -128, 14 tx_power: -128,
15 expected_tx_power: null, 15 expected_tx_power: null,
16 rssi: 0, 16 rssi: 0,
17 expected_rssi: 0 17 expected_rssi: 0
18 }, { 18 }, {
19 name: 'RSSI too low must result in nulled rssi.',
20 tx_power: 0,
21 expected_tx_power: 0,
22 rssi: -128,
23 expected_rssi: null
24 }, {
25 name: 'Low Tx Power should appear in adData.', 19 name: 'Low Tx Power should appear in adData.',
26 tx_power: -127, 20 tx_power: -127,
27 expected_tx_power: -127, 21 expected_tx_power: -127,
28 rssi: 0, 22 rssi: 0,
29 expected_rssi: 0 23 expected_rssi: 0
30 }, { 24 }, {
31 name: 'Low RSSI should appear in adData.', 25 name: 'Low RSSI should appear in adData.',
32 tx_power: 0, 26 tx_power: 0,
33 expected_tx_power: 0, 27 expected_tx_power: 0,
34 rssi: -127, 28 rssi: -128,
35 expected_rssi: -127 29 expected_rssi: -128
36 }, { 30 }, {
37 name: 'High Tx Power should appear in adData.', 31 name: 'High Tx Power should appear in adData.',
38 // TODO(ortuno): According to the Bluetooth Spec Supplement, 127 is the 32 tx_power: 127,
39 // the hightest possible valid value for Tx Power. Change to 127 when 33 expected_tx_power: 127,
40 // fixed: http://crbug.com/551572
41 tx_power: 126,
42 expected_tx_power: 126,
43 rssi: 0, 34 rssi: 0,
44 expected_rssi: 0 35 expected_rssi: 0
45 }, { 36 }, {
46 name: 'High RSSI should appear in adData.', 37 name: 'High RSSI should appear in adData.',
47 tx_power: 0, 38 tx_power: 0,
48 expected_tx_power: 0, 39 expected_tx_power: 0,
49 rssi: 126, 40 rssi: 126,
50 expected_rssi: 126 41 expected_rssi: 126
51 }, { 42 }, {
52 // TODO(ortuno): Remove this test since 127 is both a valid Tx Power
53 // and the max value of a int8.
54 // http://crbug.com/551572
55 name: 'Tx Power too high must result in nulled txPower.',
56 tx_power: 127,
57 expected_tx_power: null,
58 rssi: 0,
59 expected_rssi: 0
60 }, {
61 name: 'RSSI too high must result in nulled rssi.', 43 name: 'RSSI too high must result in nulled rssi.',
62 tx_power: 0, 44 tx_power: 0,
63 expected_tx_power: 0, 45 expected_tx_power: 0,
64 rssi: 127, 46 rssi: 127,
65 expected_rssi: null 47 expected_rssi: null
66 }].forEach(power_test => { 48 }].forEach(power_test => {
67 promise_test(() => { 49 promise_test(() => {
68 return setBluetoothFakeAdapter('PowerValueAdapter:' + 50 return setBluetoothFakeAdapter('PowerValueAdapter:' +
69 power_test.tx_power + ':' + 51 power_test.tx_power + ':' +
70 power_test.rssi) 52 power_test.rssi)
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 : null; 91 : null;
110 let expected_rssi = power_test.rssi_present ? 92 let expected_rssi = power_test.rssi_present ?
111 -51 /* power at 1m from device broadcasting at 0.1mW * / 93 -51 /* power at 1m from device broadcasting at 0.1mW * /
112 : null; 94 : null;
113 assert_equals(adv_data.txPower, expected_tx_power); 95 assert_equals(adv_data.txPower, expected_tx_power);
114 assert_equals(adv_data.rssi, expected_rssi); 96 assert_equals(adv_data.rssi, expected_rssi);
115 }); 97 });
116 }, power_test.name) 98 }, power_test.name)
117 }); 99 });
118 </script> 100 </script>
OLDNEW
« device/bluetooth/dbus/bluetooth_device_client.cc ('K') | « extensions/browser/api/bluetooth/bluetooth_api_utils.cc ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.cpp » ('j') | third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698