Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1941883002: Move the Dispatcher::EntrypointClass enum out of Dispatcher to its own file. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move the Dispatcher::EntrypointClass enum out of Dispatcher to its own file. Otherwise, everyone has to include dispatcher.h (where they're currently only forward-declaring Dispatcher), and that makes me sad. Making it a typed enum would go part way to making it forward-declarable, but of course inner types of classes can't be forward declared, so it would also have to be taken out of Dispatcher anyway. :( R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0c1fc94dba0d96d8e54d46bc5f91c7e15e4f611b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -49 lines) Patch
M mojo/edk/system/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 2 chunks +8 lines, -28 lines 0 comments Download
A mojo/edk/system/entrypoint_class.h View 1 chunk +40 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher_unittest.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-02 18:06:34 UTC) #1
azani
lgtm
4 years, 7 months ago (2016-05-02 18:29:41 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-02 19:03:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c1fc94dba0d96d8e54d46bc5f91c7e15e4f611b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698