Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 11

Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 11

Last part. Remove CFX_PtrArray typedef.

Committed: https://pdfium.googlesource.com/pdfium/+/6020e45b406e7a130024de87101b4493543f9deb

[Tom Sepez, 2016-05-02 17:28:24]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-05-02 17:28:25]

Lei, really the end (right issue this time).

[Lei Zhang, 2016-05-02 19:13:25]

lgtm

https://codereview.chromium.org/1941863002/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
File xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp (right):

https://codereview.chromium.org/1941863002/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp:116: int32_t c =
getMaxWidth(p.GetAt(0), p.GetAt(4)) < a
std::min(), for |d| as well.

https://codereview.chromium.org/1941863002/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp:122: return c < d ? c : d;
Or std::min({a, b, getMaxWidth(p.GetAt(0), p.GetAt(4)), getMaxWidth(p.GetAt(1),
p.GetAt(5))}) ?

https://codereview.chromium.org/1941863002/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp:126:
CFX_ArrayTemplate<CBC_ResultPoint*>& p) {
Can this be a const ref?

https://codereview.chromium.org/1941863002/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
File xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp (right):

https://codereview.chromium.org/1941863002/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp:473: column++;
Can't we just use |i| on line 485 instead?

[Tom Sepez, 2016-05-02 20:32:26]

https://codereview.chromium.org/1941863002/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
File xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp (right):

https://codereview.chromium.org/1941863002/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp:116: int32_t c =
getMaxWidth(p.GetAt(0), p.GetAt(4)) < a
On 2016/05/02 19:13:25, Lei Zhang (OOO) wrote:
> std::min(), for |d| as well.

Done.

https://codereview.chromium.org/1941863002/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417Reader.cpp:122: return c < d ? c : d;
On 2016/05/02 19:13:25, Lei Zhang (OOO) wrote:
> Or std::min({a, b, getMaxWidth(p.GetAt(0), p.GetAt(4)),
getMaxWidth(p.GetAt(1),
> p.GetAt(5))}) ?

or std::min(c, d) at least.

https://codereview.chromium.org/1941863002/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
File xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp (right):

https://codereview.chromium.org/1941863002/diff/1/xfa/fxbarcode/pdf417/BC_PDF...
xfa/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp:473: column++;
On 2016/05/02 19:13:25, Lei Zhang (OOO) wrote:
> Can't we just use |i| on line 485 instead?

Done.

[Tom Sepez, 2016-05-02 20:33:45]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-05-02 20:33:46]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1941863002/#ps40001
(title: "Nits.")

[commit-bot: I haz the power, 2016-05-02 20:34:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941863002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941863002/40001

[commit-bot: I haz the power, 2016-05-02 20:47:19]

Description was changed from

==========
Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 11

Last part. Remove CFX_PtrArray typedef.
==========

to

==========
Replace CFX_PtrArray with typesafe CFX_ArrayTemplate, part 11

Last part. Remove CFX_PtrArray typedef.

Committed:
https://pdfium.googlesource.com/pdfium/+/6020e45b406e7a130024de87101b4493543f...
==========

[commit-bot: I haz the power, 2016-05-02 20:47:20]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/6020e45b406e7a130024de87101b4493543f...