Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2658)

Unified Diff: appengine/monorail/search/test/query2ast_test.py

Issue 1941853002: [Monorail] Deflake the unit tests for parsing date queries. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/monorail/search/query2ast.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/monorail/search/test/query2ast_test.py
diff --git a/appengine/monorail/search/test/query2ast_test.py b/appengine/monorail/search/test/query2ast_test.py
index 63caab81ee58dc686d173b8aa8d38ba4d4593cf0..00625af8b0156afc29491d7c398ba85bc48c2a46 100644
--- a/appengine/monorail/search/test/query2ast_test.py
+++ b/appengine/monorail/search/test/query2ast_test.py
@@ -38,6 +38,7 @@ IS_NOT_DEFINED = query2ast.IS_NOT_DEFINED
KEY_HAS = query2ast.KEY_HAS
MakeCond = ast_pb2.MakeCond
+NOW = 1277762224
class QueryParsingUnitTest(unittest.TestCase):
@@ -563,9 +564,9 @@ class QueryParsingUnitTest(unittest.TestCase):
# query with a date field compared to "today"
ast = query2ast.ParseUserQuery(
'modified<today', '', BUILTIN_ISSUE_FIELDS,
- self.default_config)
+ self.default_config, now=NOW)
cond1 = ast.conjunctions[0].conds[0]
- ts1 = query2ast._CalculatePastDate(0)
+ ts1 = query2ast._CalculatePastDate(0, now=NOW)
self.assertEqual(MakeCond(LT, [BUILTIN_ISSUE_FIELDS['modified']],
[], [ts1]),
cond1)
@@ -573,17 +574,18 @@ class QueryParsingUnitTest(unittest.TestCase):
# query with a daterange using today-N alias
ast = query2ast.ParseUserQuery(
'modified>=today-13', '', BUILTIN_ISSUE_FIELDS,
- self.default_config)
+ self.default_config, now=NOW)
cond1 = ast.conjunctions[0].conds[0]
- ts1 = query2ast._CalculatePastDate(13)
+ ts1 = query2ast._CalculatePastDate(13, now=NOW)
self.assertEqual(MakeCond(GE, [BUILTIN_ISSUE_FIELDS['modified']],
[], [ts1]),
cond1)
ast = query2ast.ParseUserQuery(
- 'modified>today-13', '', BUILTIN_ISSUE_FIELDS, self.default_config)
+ 'modified>today-13', '', BUILTIN_ISSUE_FIELDS, self.default_config,
+ now=NOW)
cond1 = ast.conjunctions[0].conds[0]
- ts1 = query2ast._CalculatePastDate(13)
+ ts1 = query2ast._CalculatePastDate(13, now=NOW)
self.assertEqual(MakeCond(GT, [BUILTIN_ISSUE_FIELDS['modified']],
[], [ts1]),
cond1)
« no previous file with comments | « appengine/monorail/search/query2ast.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698