Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput)

Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput)

PushBack(end-of-input) is a little weird, but since
Utf16CharacterStream::Advance will advance pos_m, but not buffer_cursor_
when at the end of the stream, pushing back the end-of-input token needs
to do the exact inverse.

(The reason Advance does not advance buffer_cursor_ is that buffer_cursor_ is often dereferenced
 directly to access memory and so always needs to point to, well, memory.)
(The PushBack implementation for all other streams looks correct.)

R=rossberg@chromium.org
BUG=chromium:607903
LOG=Y

Committed: https://crrev.com/57f0a521e40a96bab629ca6618c9f939653f8a06
Cr-Commit-Position: refs/heads/master@{#35968}

[vogelheim, 2016-05-02 16:55:49]

Description was changed from

==========
Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput)

PushBack(end-of-input) is a little weird, but since
Utf16CharacterStream::Advance will advance pos_m, but not buffer_cursor_
when at the end of the stream, pushing back the end-of-input token needs
to do the exact inverse.

(The reason Advance does not advance buffer_cursor_ is often dereferenced
 directly to access memory and so always needs to point to, well, memory.)
(The PushBack implementation for all other streams looks correct.)

R=rossberg@chromium.org
BUG=chromium:607903
==========

to

==========
Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput)

PushBack(end-of-input) is a little weird, but since
Utf16CharacterStream::Advance will advance pos_m, but not buffer_cursor_
when at the end of the stream, pushing back the end-of-input token needs
to do the exact inverse.

(The reason Advance does not advance buffer_cursor_ is often dereferenced
 directly to access memory and so always needs to point to, well, memory.)
(The PushBack implementation for all other streams looks correct.)

R=rossberg@chromium.org
BUG=chromium:607903
LOG=Y
==========

[vogelheim, 2016-05-02 17:02:42]

Description was changed from

==========
Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput)

PushBack(end-of-input) is a little weird, but since
Utf16CharacterStream::Advance will advance pos_m, but not buffer_cursor_
when at the end of the stream, pushing back the end-of-input token needs
to do the exact inverse.

(The reason Advance does not advance buffer_cursor_ is often dereferenced
 directly to access memory and so always needs to point to, well, memory.)
(The PushBack implementation for all other streams looks correct.)

R=rossberg@chromium.org
BUG=chromium:607903
LOG=Y
==========

to

==========
Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput)

PushBack(end-of-input) is a little weird, but since
Utf16CharacterStream::Advance will advance pos_m, but not buffer_cursor_
when at the end of the stream, pushing back the end-of-input token needs
to do the exact inverse.

(The reason Advance does not advance buffer_cursor_ is that buffer_cursor_ is
often dereferenced
 directly to access memory and so always needs to point to, well, memory.)
(The PushBack implementation for all other streams looks correct.)

R=rossberg@chromium.org
BUG=chromium:607903
LOG=Y
==========

[rossberg, 2016-05-03 09:15:04]

lgtm

[vogelheim, 2016-05-03 09:37:17]

The CQ bit was checked by vogelheim@chromium.org

[commit-bot: I haz the power, 2016-05-03 09:37:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941843002/1

[commit-bot: I haz the power, 2016-05-03 09:41:39]

Description was changed from

==========
Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput)

PushBack(end-of-input) is a little weird, but since
Utf16CharacterStream::Advance will advance pos_m, but not buffer_cursor_
when at the end of the stream, pushing back the end-of-input token needs
to do the exact inverse.

(The reason Advance does not advance buffer_cursor_ is that buffer_cursor_ is
often dereferenced
 directly to access memory and so always needs to point to, well, memory.)
(The PushBack implementation for all other streams looks correct.)

R=rossberg@chromium.org
BUG=chromium:607903
LOG=Y
==========

to

==========
Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput)

PushBack(end-of-input) is a little weird, but since
Utf16CharacterStream::Advance will advance pos_m, but not buffer_cursor_
when at the end of the stream, pushing back the end-of-input token needs
to do the exact inverse.

(The reason Advance does not advance buffer_cursor_ is that buffer_cursor_ is
often dereferenced
 directly to access memory and so always needs to point to, well, memory.)
(The PushBack implementation for all other streams looks correct.)

R=rossberg@chromium.org
BUG=chromium:607903
LOG=Y
==========

[commit-bot: I haz the power, 2016-05-03 09:41:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-03 09:43:52]

Description was changed from

==========
Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput)

PushBack(end-of-input) is a little weird, but since
Utf16CharacterStream::Advance will advance pos_m, but not buffer_cursor_
when at the end of the stream, pushing back the end-of-input token needs
to do the exact inverse.

(The reason Advance does not advance buffer_cursor_ is that buffer_cursor_ is
often dereferenced
 directly to access memory and so always needs to point to, well, memory.)
(The PushBack implementation for all other streams looks correct.)

R=rossberg@chromium.org
BUG=chromium:607903
LOG=Y
==========

to

==========
Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput)

PushBack(end-of-input) is a little weird, but since
Utf16CharacterStream::Advance will advance pos_m, but not buffer_cursor_
when at the end of the stream, pushing back the end-of-input token needs
to do the exact inverse.

(The reason Advance does not advance buffer_cursor_ is that buffer_cursor_ is
often dereferenced
 directly to access memory and so always needs to point to, well, memory.)
(The PushBack implementation for all other streams looks correct.)

R=rossberg@chromium.org
BUG=chromium:607903
LOG=Y

Committed: https://crrev.com/57f0a521e40a96bab629ca6618c9f939653f8a06
Cr-Commit-Position: refs/heads/master@{#35968}
==========

[commit-bot: I haz the power, 2016-05-03 09:43:53]

Patchset 1 (id:??) landed as
https://crrev.com/57f0a521e40a96bab629ca6618c9f939653f8a06
Cr-Commit-Position: refs/heads/master@{#35968}