Properly disallow 'yield' in class expressions and arrow parameters

Properly disallow 'yield' in class expressions and arrow parameters

Yield expressions are not allowed in formal parameter initializers of
generators, but we weren't properly catching the case where the yield
expression appeared in the 'extends' clause of a class expression.

They also aren't allowed in arrow functions, which we were failing to
catch due to not looking at the obscurely-named "FormalParameterInitializerError"
bit of ExpressionClassifier.

This patch passes along an ExpressionClassifier when parsing class
expressions and accumulates the proper error for that case.

For the arrow function case, the fix is simply to check for the
"formal parameter initializer" error once we know we've parsed
an arrow function. The error message used for this has also
been made specific to yield expressions.

Tests are added both for the error case and the non-error cases (where
yield is used in such a position inside the class body).

BUG=v8:4966, v8:4968, v8:4974
LOG=n

Committed: https://crrev.com/9e9abcfff46084f60ad83acb26f56f13ac04347f
Cr-Commit-Position: refs/heads/master@{#35957}

[adamk, 2016-05-02 20:46:21]

adamk@chromium.org changed reviewers:
+ caitpotter88@gmail.com, littledan@chromium.org

[adamk, 2016-05-02 22:37:03]

Description was changed from

==========
Properly disallow 'yield' in class expressions where needed

Yield expressions are not allowed in formal parameter initiazers of
generators, but we weren't properly catching the case where the yield
expression appeared in the 'extends' clause of a class expression.

This patch passes along an ExpressionClassifier when parsing class
expressions and accumulates the proper error.

Tests are added both for the error case and the non-error cases (where
yield is used in such a position inside the class body).

BUG=v8:4974
LOG=n
==========

to

==========
Properly disallow 'yield' in class expressions where needed

Yield expressions are not allowed in formal parameter initiazers of
generators, but we weren't properly catching the case where the yield
expression appeared in the 'extends' clause of a class expression.

This patch passes along an ExpressionClassifier when parsing class
expressions and accumulates the proper error.

Tests are added both for the error case and the non-error cases (where
yield is used in such a position inside the class body).

BUG=v8:4966, v8:4968, v8:4974
LOG=n
==========

[adamk, 2016-05-02 22:40:46]

Description was changed from

==========
Properly disallow 'yield' in class expressions where needed

Yield expressions are not allowed in formal parameter initiazers of
generators, but we weren't properly catching the case where the yield
expression appeared in the 'extends' clause of a class expression.

This patch passes along an ExpressionClassifier when parsing class
expressions and accumulates the proper error.

Tests are added both for the error case and the non-error cases (where
yield is used in such a position inside the class body).

BUG=v8:4966, v8:4968, v8:4974
LOG=n
==========

to

==========
Properly disallow 'yield' in class expressions and arrow parameters

Yield expressions are not allowed in formal parameter initializers of
generators, but we weren't properly catching the case where the yield
expression appeared in the 'extends' clause of a class expression.

They also aren't allowed in arrow functions, which we were failing to
catch due to not looking at the obscurely-named
"FormalParameterInitializerError"
bit of ExpressionClassifier.

This patch passes along an ExpressionClassifier when parsing class
expressions and accumulates the proper error for that case.

For the arrow function case, the fix is simply to check for the
"formal parameter initializer" error once we know we've parsed
an arrow function.

Tests are added both for the error case and the non-error cases (where
yield is used in such a position inside the class body).

BUG=v8:4966, v8:4968, v8:4974
LOG=n
==========

[adamk, 2016-05-02 22:41:08]

Now this fixes all the things (with a TODO to fix the naming).

[adamk, 2016-05-02 23:00:38]

Description was changed from

==========
Properly disallow 'yield' in class expressions and arrow parameters

Yield expressions are not allowed in formal parameter initializers of
generators, but we weren't properly catching the case where the yield
expression appeared in the 'extends' clause of a class expression.

They also aren't allowed in arrow functions, which we were failing to
catch due to not looking at the obscurely-named
"FormalParameterInitializerError"
bit of ExpressionClassifier.

This patch passes along an ExpressionClassifier when parsing class
expressions and accumulates the proper error for that case.

For the arrow function case, the fix is simply to check for the
"formal parameter initializer" error once we know we've parsed
an arrow function.

Tests are added both for the error case and the non-error cases (where
yield is used in such a position inside the class body).

BUG=v8:4966, v8:4968, v8:4974
LOG=n
==========

to

==========
Properly disallow 'yield' in class expressions and arrow parameters

Yield expressions are not allowed in formal parameter initializers of
generators, but we weren't properly catching the case where the yield
expression appeared in the 'extends' clause of a class expression.

They also aren't allowed in arrow functions, which we were failing to
catch due to not looking at the obscurely-named
"FormalParameterInitializerError"
bit of ExpressionClassifier.

This patch passes along an ExpressionClassifier when parsing class
expressions and accumulates the proper error for that case.

For the arrow function case, the fix is simply to check for the
"formal parameter initializer" error once we know we've parsed
an arrow function. The error message used for this has also
been made specific to yield expressions.

Tests are added both for the error case and the non-error cases (where
yield is used in such a position inside the class body).

BUG=v8:4966, v8:4968, v8:4974
LOG=n
==========

[Dan Ehrenberg, 2016-05-02 23:11:43]

lgtm

https://codereview.chromium.org/1941823003/diff/80001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/1941823003/diff/80001/src/parsing/parser-base...
src/parsing/parser-base.h:1989: // "YieldExpression", which is its only use.
You probably want to remove this TODO

[adamk, 2016-05-02 23:14:18]

https://codereview.chromium.org/1941823003/diff/80001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/1941823003/diff/80001/src/parsing/parser-base...
src/parsing/parser-base.h:1989: // "YieldExpression", which is its only use.
On 2016/05/02 23:11:43, Dan Ehrenberg wrote:
> You probably want to remove this TODO

I actually also want to rename the methods on ExpressionClassifier to be more
specific, which is what this TODO is about.

[adamk, 2016-05-02 23:14:24]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-05-02 23:14:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941823003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941823003/80001

[commit-bot: I haz the power, 2016-05-03 01:55:36]

Description was changed from

==========
Properly disallow 'yield' in class expressions and arrow parameters

Yield expressions are not allowed in formal parameter initializers of
generators, but we weren't properly catching the case where the yield
expression appeared in the 'extends' clause of a class expression.

They also aren't allowed in arrow functions, which we were failing to
catch due to not looking at the obscurely-named
"FormalParameterInitializerError"
bit of ExpressionClassifier.

This patch passes along an ExpressionClassifier when parsing class
expressions and accumulates the proper error for that case.

For the arrow function case, the fix is simply to check for the
"formal parameter initializer" error once we know we've parsed
an arrow function. The error message used for this has also
been made specific to yield expressions.

Tests are added both for the error case and the non-error cases (where
yield is used in such a position inside the class body).

BUG=v8:4966, v8:4968, v8:4974
LOG=n
==========

to

==========
Properly disallow 'yield' in class expressions and arrow parameters

Yield expressions are not allowed in formal parameter initializers of
generators, but we weren't properly catching the case where the yield
expression appeared in the 'extends' clause of a class expression.

They also aren't allowed in arrow functions, which we were failing to
catch due to not looking at the obscurely-named
"FormalParameterInitializerError"
bit of ExpressionClassifier.

This patch passes along an ExpressionClassifier when parsing class
expressions and accumulates the proper error for that case.

For the arrow function case, the fix is simply to check for the
"formal parameter initializer" error once we know we've parsed
an arrow function. The error message used for this has also
been made specific to yield expressions.

Tests are added both for the error case and the non-error cases (where
yield is used in such a position inside the class body).

BUG=v8:4966, v8:4968, v8:4974
LOG=n
==========

[commit-bot: I haz the power, 2016-05-03 01:55:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-03 01:57:53]

Description was changed from

==========
Properly disallow 'yield' in class expressions and arrow parameters

Yield expressions are not allowed in formal parameter initializers of
generators, but we weren't properly catching the case where the yield
expression appeared in the 'extends' clause of a class expression.

They also aren't allowed in arrow functions, which we were failing to
catch due to not looking at the obscurely-named
"FormalParameterInitializerError"
bit of ExpressionClassifier.

This patch passes along an ExpressionClassifier when parsing class
expressions and accumulates the proper error for that case.

For the arrow function case, the fix is simply to check for the
"formal parameter initializer" error once we know we've parsed
an arrow function. The error message used for this has also
been made specific to yield expressions.

Tests are added both for the error case and the non-error cases (where
yield is used in such a position inside the class body).

BUG=v8:4966, v8:4968, v8:4974
LOG=n
==========

to

==========
Properly disallow 'yield' in class expressions and arrow parameters

Yield expressions are not allowed in formal parameter initializers of
generators, but we weren't properly catching the case where the yield
expression appeared in the 'extends' clause of a class expression.

They also aren't allowed in arrow functions, which we were failing to
catch due to not looking at the obscurely-named
"FormalParameterInitializerError"
bit of ExpressionClassifier.

This patch passes along an ExpressionClassifier when parsing class
expressions and accumulates the proper error for that case.

For the arrow function case, the fix is simply to check for the
"formal parameter initializer" error once we know we've parsed
an arrow function. The error message used for this has also
been made specific to yield expressions.

Tests are added both for the error case and the non-error cases (where
yield is used in such a position inside the class body).

BUG=v8:4966, v8:4968, v8:4974
LOG=n

Committed: https://crrev.com/9e9abcfff46084f60ad83acb26f56f13ac04347f
Cr-Commit-Position: refs/heads/master@{#35957}
==========

[commit-bot: I haz the power, 2016-05-03 01:57:54]

Patchset 5 (id:??) landed as
https://crrev.com/9e9abcfff46084f60ad83acb26f56f13ac04347f
Cr-Commit-Position: refs/heads/master@{#35957}