Use null aware operators to clean up code

Use null aware operators to clean up code

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/7a9b2a3133f5b8b418b38ddd6781634b58bcaab2

[Brian Wilkerson, 2016-05-02 14:57:38]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-05-02 15:22:43]

LGTM

https://codereview.chromium.org/1941793002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/computer/computer_outline.dart (right):

https://codereview.chromium.org/1941793002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/computer_outline.dart:387: node == null ?
'' : node.toSource();
node?.toSource() ?? ''

Not that it is much better, but just in case if you accidentally missed it.

[Brian Wilkerson, 2016-05-02 15:28:09]

https://codereview.chromium.org/1941793002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/computer/computer_outline.dart (right):

https://codereview.chromium.org/1941793002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/computer_outline.dart:387: node == null ?
'' : node.toSource();
> node?.toSource() ?? ''
> 
> Not that it is much better, but just in case if you accidentally missed it.

Is that better? Looks to me like this would incur the cost of two null checks,
while the other only has one. Not that null checks are expensive, but...

[scheglov, 2016-05-02 15:29:58]

https://codereview.chromium.org/1941793002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/computer/computer_outline.dart (right):

https://codereview.chromium.org/1941793002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/computer_outline.dart:387: node == null ?
'' : node.toSource();
On 2016/05/02 15:28:09, Brian Wilkerson wrote:
> > node?.toSource() ?? ''
> > 
> > Not that it is much better, but just in case if you accidentally missed it.
> 
> Is that better? Looks to me like this would incur the cost of two null checks,
> while the other only has one. Not that null checks are expensive, but...

You're right, it isn't better.

[Brian Wilkerson, 2016-05-02 15:38:47]

Description was changed from

==========
Use null aware operators to clean up code
==========

to

==========
Use null aware operators to clean up code

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7a9b2a3133f5b8b418b38ddd6781634b58bcaab2
==========

[Brian Wilkerson, 2016-05-02 15:38:49]

Committed patchset #1 (id:1) manually as
7a9b2a3133f5b8b418b38ddd6781634b58bcaab2 (presubmit successful).