Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1941733002: Don't cache parsed stylesheet if it wasn't added to the memory cache. (Closed)

Created:
4 years, 7 months ago by rune
Modified:
4 years, 7 months ago
Reviewers:
sof
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't cache parsed stylesheet if it wasn't added to the memory cache. The code expects the StyleSheetContents to be in the memory cache when pointed to by m_parsedStyleSheetCache. Set m_parsedStyleSheetCache to nullptr initially when the StyleSheetContents could not be added to the memory cache. R=sigbjornf@opera.com BUG=606248 Committed: https://crrev.com/c7032f96c614bec3b23c6b6ec6f371db5a84a0cc Cr-Commit-Position: refs/heads/master@{#390949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
ptal
4 years, 7 months ago (2016-05-02 11:45:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941733002/1
4 years, 7 months ago (2016-05-02 11:45:33 UTC) #3
sof
lgtm
4 years, 7 months ago (2016-05-02 12:05:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-02 14:15:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941733002/1
4 years, 7 months ago (2016-05-02 14:21:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 15:39:34 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 15:42:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7032f96c614bec3b23c6b6ec6f371db5a84a0cc
Cr-Commit-Position: refs/heads/master@{#390949}

Powered by Google App Engine
This is Rietveld 408576698