Issue 19417: Generate a file name when dragging an image to the desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19417: Generate a file name when dragging an image to the desktop (Closed)

Created:
11 years, 11 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Generate a proper file name when dragging an image from a web page to the desktop. We receive information about the image from WebKit in the render which includes the image URL, MIME type and a guess as to what the file name is. If the filename is empty, we synthesize a file name based on the URL. In all cases, we set the file extension to the MIME type that was detected by WebKit. This change is the Chromium portion of image dragging. The WebKit portion has been committed as: http://trac.webkit.org/changeset/40294 BUG=6481 (http://crbug.com/6481) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8854

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
M	chrome/browser/tab_contents/web_contents_view_win.cc	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/clipboard_conversion.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/webdropdata.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.  This patch turned out well.  Thanks Paul.

Expand Messages | Collapse Messages