Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 19417: Generate a file name when dragging an image to the desktop (Closed)

Created:
10 years, 6 months ago by Paul Godavari
Modified:
8 years, 3 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Generate a proper file name when dragging an image from a web page to the desktop. We receive information about the image from WebKit in the render which includes the image URL, MIME type and a guess as to what the file name is. If the filename is empty, we synthesize a file name based on the URL. In all cases, we set the file extension to the MIME type that was detected by WebKit. This change is the Chromium portion of image dragging. The WebKit portion has been committed as: http://trac.webkit.org/changeset/40294 BUG=6481 (http://crbug.com/6481) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8854

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M chrome/browser/tab_contents/web_contents_view_win.cc View 1 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/glue/clipboard_conversion.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/glue/webdropdata.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Godavari
10 years, 6 months ago (2009-01-28 19:00:06 UTC) #1
abarth-chromium
10 years, 6 months ago (2009-01-29 00:16:33 UTC) #2
LGTM.  This patch turned out well.  Thanks Paul.

Powered by Google App Engine
This is Rietveld 408576698