Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1941633002: PaymentResponse tests (Closed)

Created:
4 years, 7 months ago by please use gerrit instead
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentResponse tests - Verify that PaymentResponse.details contains the parsed stringified JSON object with instrument details. - Verify that PaymentResponse.complete(boolean) will forward the correct boolean boolean value to the implementation of the PaymentCompleter. BUG=587995 Committed: https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e Cr-Commit-Position: refs/heads/master@{#391047}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address comments #

Patch Set 3 : Remove dependency on an other patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp View 1 5 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
please use gerrit instead
mek@, ptal. I had a TODO to verify more details in PaymentResponseTest.cpp and finally got ...
4 years, 7 months ago (2016-05-01 23:16:43 UTC) #2
Marijn Kruisselbrink
looks mostly good. Please add a more descriptive CL description/commit message though. https://codereview.chromium.org/1941633002/diff/1/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp File third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp ...
4 years, 7 months ago (2016-05-02 18:04:59 UTC) #3
please use gerrit instead
https://codereview.chromium.org/1941633002/diff/1/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp File third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp (left): https://codereview.chromium.org/1941633002/diff/1/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp#oldcode18 third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp:18: namespace { On 2016/05/02 18:04:58, Marijn Kruisselbrink wrote: > ...
4 years, 7 months ago (2016-05-02 18:17:25 UTC) #5
please use gerrit instead
ptal patch 2.
4 years, 7 months ago (2016-05-02 18:17:39 UTC) #6
Marijn Kruisselbrink
lgtm https://codereview.chromium.org/1941633002/diff/1/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp File third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp (left): https://codereview.chromium.org/1941633002/diff/1/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp#oldcode18 third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp:18: namespace { On 2016/05/02 at 18:17:24, Rouslan wrote: ...
4 years, 7 months ago (2016-05-02 18:53:49 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 1938853002 Patch 1). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-02 19:00:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941633002/40001
4 years, 7 months ago (2016-05-02 19:16:55 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-02 20:37:11 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 20:38:42 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5f33419202c68e3272053961ef89562e80352f5e
Cr-Commit-Position: refs/heads/master@{#391047}

Powered by Google App Engine
This is Rietveld 408576698