Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1941603002: gc plugin: stop recognizing old and unused options. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gc plugin: stop recognizing old and unused options. The options "enable-oilpan" and "warn-raw-ptr" are following r390631 no longer being passed in as options, hence we can finally stop recognizing them. R= BUG=585328 Committed: https://crrev.com/11d39c1b27d7c35d9196edbfc7e82a3551c9eec8 Cr-Commit-Position: refs/heads/master@{#390875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 chunk +7 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-01 16:12:36 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-01 17:35:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941603002/1
4 years, 7 months ago (2016-05-01 21:49:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-01 21:55:01 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 21:56:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11d39c1b27d7c35d9196edbfc7e82a3551c9eec8
Cr-Commit-Position: refs/heads/master@{#390875}

Powered by Google App Engine
This is Rietveld 408576698