[Mac][Material Design] Update bookmarks bar to Material Design.

[Mac][Material Design] Update bookmarks bar to Material Design.

This cl changes the bookmarks bar folder icons, button sizes, and hover
state to match the Material Design spec.

R=avi@chromium.org,cpu@chromium.org
BUG=589941
Committed: https://crrev.com/e757665e44c261568486d052ecf38d79256a522d
Cr-Commit-Position: refs/heads/master@{#394165}

[shrike, 2016-04-30 20:13:29]

Description was changed from

==========
[Mac][Material Design] Update bookmarks bar to Material Design.

This cl changes the bookmarks bar folder icons, button sizes, and hover
state to match the Material Design spec.

BUG=589941
==========

to

==========
[Mac][Material Design] Update bookmarks bar to Material Design.

This cl changes the bookmarks bar folder icons, button sizes, and hover
state to match the Material Design spec.

BUG=589941
==========

[upolat, 2016-05-09 23:16:44]

ugurcan.polat12@gmail.com changed reviewers:
+ ugurcan.polat12@gmail.com

[upolat, 2016-05-09 23:16:45]

https://codereview.chromium.org/1941583002/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/gradient_button_cell.mm (right):

https://codereview.chromium.org/1941583002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/gradient_button_cell.mm:331: // THe user has just
clicked down in the button. In Material Design, set the
typo: THe

[shrike, 2016-05-09 23:36:46]

Description was changed from

==========
[Mac][Material Design] Update bookmarks bar to Material Design.

This cl changes the bookmarks bar folder icons, button sizes, and hover
state to match the Material Design spec.

BUG=589941
==========

to

==========
[Mac][Material Design] Update bookmarks bar to Material Design.

This cl changes the bookmarks bar folder icons, button sizes, and hover
state to match the Material Design spec.

R=avi@chromium.org,cpu@chromium.org
BUG=589941
==========

[shrike, 2016-05-09 23:36:46]

shrike@chromium.org changed reviewers:
+ avi@chromium.org, cpu@chromium.org
- ugurcan.polat12@gmail.com

[shrike, 2016-05-09 23:41:33]

shrike@chromium.org changed reviewers:
+ ugurcan.polat12@gmail.com

[shrike, 2016-05-09 23:42:37]

PTAL

avi:
  chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h
  chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
  chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
  chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
  chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
  chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
  chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm
  chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
  chrome/browser/ui/cocoa/gradient_button_cell.h
  chrome/browser/ui/cocoa/gradient_button_cell.mm
cpu:
  chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_managed_white.png
 
chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_supervised_white.png
  chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_white.png
  chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_managed_white.png
 
chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_supervised_white.png
  chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_white.png
  chrome/app/theme/material_100_percent/mac/bookmark_bar_folder.png
  chrome/app/theme/material_100_percent/mac/bookmark_bar_folder_managed.png
  chrome/app/theme/material_100_percent/mac/bookmark_bar_folder_supervised.png
  chrome/app/theme/material_200_percent/mac/bookmark_bar_folder.png
  chrome/app/theme/material_200_percent/mac/bookmark_bar_folder_managed.png
  chrome/app/theme/material_200_percent/mac/bookmark_bar_folder_supervised.png
  chrome/app/theme/theme_resources.grd

https://codereview.chromium.org/1941583002/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/gradient_button_cell.mm (right):

https://codereview.chromium.org/1941583002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/gradient_button_cell.mm:331: // THe user has just
clicked down in the button. In Material Design, set the
On 2016/05/09 23:16:45, upolat wrote:
> typo: THe

Done.

[Avi (use Gerrit), 2016-05-10 01:06:09]

lgtm

[shrike, 2016-05-11 19:07:44]

cpu@ - would you please approve addition of these icons to Chrome? This is an
important change for Material Design and I'm hoping to get it landed soon so
that it can start getting some airtime. Thank you.

[shrike, 2016-05-11 22:18:45]

shrike@chromium.org changed reviewers:
+ sky@chromium.org

[shrike, 2016-05-11 22:19:47]

sky@ - are you able to approve my PNG additions in this cl? I'm trying to land
this cl today (needed for launch review tomorrow). Thank you for your help.

[cpu_(ooo_6.6-7.5), 2016-05-12 00:27:14]

chrome/app/theme lgtm

[shrike, 2016-05-12 00:38:15]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-05-12 00:38:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941583002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941583002/100001

[commit-bot: I haz the power, 2016-05-12 00:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 00:52:18]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shrike, 2016-05-12 02:48:44]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-05-12 02:48:45]

The patchset sent to the CQ was uploaded after l-g-t-m from cpu@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1941583002/#ps120001
(title: "Fix compile problem.")

[commit-bot: I haz the power, 2016-05-12 02:49:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941583002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941583002/120001

[commit-bot: I haz the power, 2016-05-12 03:05:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 03:05:21]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[shrike, 2016-05-12 20:59:43]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-05-12 20:59:44]

The patchset sent to the CQ was uploaded after l-g-t-m from cpu@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1941583002/#ps160001
(title: "Fix test and nit.")

[commit-bot: I haz the power, 2016-05-12 21:00:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941583002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941583002/160001

[commit-bot: I haz the power, 2016-05-12 21:48:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 21:48:59]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[shrike, 2016-05-17 16:53:53]

avi@ - will you take a look the changes I've made since your approval? Thank
you.

[shrike, 2016-05-17 16:54:09]

shrike@chromium.org changed reviewers:
- sky@chromium.org

[Avi (use Gerrit), 2016-05-17 16:57:51]

lgtm

[shrike, 2016-05-17 16:59:05]

The CQ bit was checked by shrike@chromium.org

[shrike, 2016-05-17 16:59:05]

The patchset sent to the CQ was uploaded after l-g-t-m from cpu@chromium.org
Link to the patchset: https://codereview.chromium.org/1941583002/#ps320001
(title: "Convert bookmarks overflow button to MD.")

[commit-bot: I haz the power, 2016-05-17 16:59:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941583002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941583002/320001

[commit-bot: I haz the power, 2016-05-17 18:06:16]

Description was changed from

==========
[Mac][Material Design] Update bookmarks bar to Material Design.

This cl changes the bookmarks bar folder icons, button sizes, and hover
state to match the Material Design spec.

R=avi@chromium.org,cpu@chromium.org
BUG=589941
==========

to

==========
[Mac][Material Design] Update bookmarks bar to Material Design.

This cl changes the bookmarks bar folder icons, button sizes, and hover
state to match the Material Design spec.

R=avi@chromium.org,cpu@chromium.org
BUG=589941
==========

[commit-bot: I haz the power, 2016-05-17 18:06:17]

Committed patchset #17 (id:320001)

[commit-bot: I haz the power, 2016-05-17 18:09:43]

Description was changed from

==========
[Mac][Material Design] Update bookmarks bar to Material Design.

This cl changes the bookmarks bar folder icons, button sizes, and hover
state to match the Material Design spec.

R=avi@chromium.org,cpu@chromium.org
BUG=589941
==========

to

==========
[Mac][Material Design] Update bookmarks bar to Material Design.

This cl changes the bookmarks bar folder icons, button sizes, and hover
state to match the Material Design spec.

R=avi@chromium.org,cpu@chromium.org
BUG=589941

Committed: https://crrev.com/e757665e44c261568486d052ecf38d79256a522d
Cr-Commit-Position: refs/heads/master@{#394165}
==========

[commit-bot: I haz the power, 2016-05-17 18:09:44]

Patchset 17 (id:??) landed as
https://crrev.com/e757665e44c261568486d052ecf38d79256a522d
Cr-Commit-Position: refs/heads/master@{#394165}

[qyearsley, 2016-05-17 23:14:52]

A revert of this CL (patchset #17 id:320001) has been created in
https://codereview.chromium.org/1986963004/ by qyearsley@chromium.org.

The reason for reverting is: Appears to have caused failure in unit test
BookmarkBarControllerTest.LastBookmarkResizeBehavior on Mac 10.11

Logs:
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/16...

Build:
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/1621.

[shrike, 2016-05-17 23:18:21]

Description was changed from

==========
[Mac][Material Design] Update bookmarks bar to Material Design.

This cl changes the bookmarks bar folder icons, button sizes, and hover
state to match the Material Design spec.

R=avi@chromium.org,cpu@chromium.org
BUG=589941

Committed: https://crrev.com/e757665e44c261568486d052ecf38d79256a522d
Cr-Commit-Position: refs/heads/master@{#394165}
==========

to

==========
[Mac][Material Design] Update bookmarks bar to Material Design.

This cl changes the bookmarks bar folder icons, button sizes, and hover
state to match the Material Design spec.

R=avi@chromium.org,cpu@chromium.org
BUG=589941

Committed: https://crrev.com/e757665e44c261568486d052ecf38d79256a522d
Cr-Commit-Position: refs/heads/master@{#394165}
==========