Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1941573002: [tools] Handle benchmark runs reporting more than one result. (Closed)

Created:
4 years, 7 months ago by Mircea Trofin
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Clemens Hammacher
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Handle benchmark runs reporting more than one result. The Wasm suite reports both compile time and code size, however, perf-to-html.py elides one of the results (compile time, in this case). This affects the effectiveness of results reported by perf try bot runs. This CL addresses that. BUG= Committed: https://crrev.com/81db29dd10ad17e059674ecca83213297eae0d0c Cr-Commit-Position: refs/heads/master@{#35935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf-to-html.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
4 years, 7 months ago (2016-04-30 16:18:18 UTC) #3
Michael Achenbach
lgtm
4 years, 7 months ago (2016-05-02 07:04:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941573002/1
4 years, 7 months ago (2016-05-02 14:02:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 14:23:13 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 14:25:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81db29dd10ad17e059674ecca83213297eae0d0c
Cr-Commit-Position: refs/heads/master@{#35935}

Powered by Google App Engine
This is Rietveld 408576698