Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1941563002: Revert of Allow overriding GN build flags (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Allow overriding GN build flags (patchset #2 id:20001 of https://codereview.chromium.org/1923333002/ ) Reason for revert: Blocking the roll Original issue's description: > Allow overriding GN build flags > > In order to enable XFA from GN builds we need to be able to override > pdf_enable_xfa. To do this a build_overrides/pdfium.gni file needs to be created > in Chrome. To use that, we have to create a build_overrides/pdfium.gni file > in PDFium that just uses the default values. > > BUG=chromium:62400 > > Committed: https://pdfium.googlesource.com/pdfium/+/1ae572e7e35b52ce4897d1715c005a1b0f79526a TBR=thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:62400 Committed: https://pdfium.googlesource.com/pdfium/+/038bf0b129e56212a6de0989dca1ae023bb17c5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D build_overrides/pdfium.gni View 1 chunk +0 lines, -23 lines 0 comments Download
A pdfium.gni View 1 chunk +23 lines, -0 lines 0 comments Download
M samples/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M testing/libfuzzer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
dsinclair
Created Revert of Allow overriding GN build flags
4 years, 7 months ago (2016-04-30 12:47:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941563002/1
4 years, 7 months ago (2016-04-30 12:47:54 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 13:00:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/038bf0b129e56212a6de0989dca1ae023bb1...

Powered by Google App Engine
This is Rietveld 408576698