Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1941523002: Aura Window Capture: Ensure capture callback is always run. (Closed)

Created:
4 years, 7 months ago by miu
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Aura Window Capture: Ensure capture callback is always run. The capture callback must always be run, or eventually the capture decision logic will think there are too many captures in-flight. This closes some "holes" in content::AuraWindowCaptureMachine where methods exit early without running the callback. This is a potential fix for crbug 600031. BUG=600031 Review URL: https://codereview.chromium.org/1913283004 Cr-Commit-Position: refs/heads/master@{#389867} (cherry picked from commit 47efd876604698bfebe78ef495d789148694f649) Committed: https://chromium.googlesource.com/chromium/src/+/a6a5c05b36174ab04dc9ed3ec125b799e4182653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M content/browser/media/capture/aura_window_capture_machine.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M media/capture/content/thread_safe_capture_oracle.h View 1 chunk +4 lines, -3 lines 0 comments Download
M media/capture/content/thread_safe_capture_oracle.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
miu
4 years, 7 months ago (2016-04-29 23:30:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6a5c05b36174ab04dc9ed3ec125b799e4182653.

Powered by Google App Engine
This is Rietveld 408576698