Make servicing of SMIL animations require a FrameView

Make servicing of SMIL animations require a FrameView

SMIL animations are not running (or even started) in inactive documents,
and scheduling frames requires a FrameView. Hence it makes sense to move
the call to SVGDocumentExtensions::serviceOnAnimationFrame into the
block that requires a FrameView.
Drop unused timestamp argument to SMILTimeContainer::serviceAnimations,
and let that propagate all the way out to PageAnimator.

Committed: https://crrev.com/a4afc11bf0f7caad494854d539c2e5bc11844496
Cr-Commit-Position: refs/heads/master@{#391244}

[fs, 2016-05-03 12:26:11]

fs@opera.com changed reviewers:
+ skyostil@chromium.org

[fs, 2016-05-03 12:26:14]

Don't know if you had any bug in mind for the TODO, but I didn't find one.

[Sami, 2016-05-03 13:17:12]

Requiring FrameViews for animating SMIL sounds fine to me. I think we might want
to keep the animation time plumbing around though, and add a TODO to
SMILTimeContainer.cpp to actually start using it. We shouldn't be trying to run
animations based on elapsed wall time anymore since that results in jitter and
loss of synchronization.

[fs, 2016-05-03 13:23:04]

On 2016/05/03 at 13:17:12, skyostil wrote:
> Requiring FrameViews for animating SMIL sounds fine to me. I think we might
want to keep the animation time plumbing around though, and add a TODO to
SMILTimeContainer.cpp to actually start using it. We shouldn't be trying to run
animations based on elapsed wall time anymore since that results in jitter and
loss of synchronization.

SMIL animations are using the Document AnimationClock (just like CSS
animations), so it's using the timestamp already, just that it does so
indirectly.

[Sami, 2016-05-03 15:19:52]

On 2016/05/03 13:23:04, fs wrote:
> SMIL animations are using the Document AnimationClock (just like CSS
> animations), so it's using the timestamp already, just that it does so
> indirectly.

Great, I didn't realize it was wired up that way. lgtm.

[fs, 2016-05-03 15:30:26]

On 2016/05/03 at 15:19:52, skyostil wrote:
> On 2016/05/03 13:23:04, fs wrote:
> > SMIL animations are using the Document AnimationClock (just like CSS
> > animations), so it's using the timestamp already, just that it does so
> > indirectly.
> 
> Great, I didn't realize it was wired up that way. lgtm.

I should probably have said "Document AnimationTimeline", but it's the right
clock anyway...

[fs, 2016-05-03 15:30:42]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-05-03 15:32:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941403002/1

[commit-bot: I haz the power, 2016-05-03 15:38:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-03 15:39:47]

Description was changed from

==========
Make servicing of SMIL animations require a FrameView

SMIL animations are not running (or even started) in inactive documents,
and scheduling frames requires a FrameView. Hence it makes sense to move
the call to SVGDocumentExtensions::serviceOnAnimationFrame into the
block that requires a FrameView.
Drop unused timestamp argument to SMILTimeContainer::serviceAnimations,
and let that propagate all the way out to PageAnimator.
==========

to

==========
Make servicing of SMIL animations require a FrameView

SMIL animations are not running (or even started) in inactive documents,
and scheduling frames requires a FrameView. Hence it makes sense to move
the call to SVGDocumentExtensions::serviceOnAnimationFrame into the
block that requires a FrameView.
Drop unused timestamp argument to SMILTimeContainer::serviceAnimations,
and let that propagate all the way out to PageAnimator.

Committed: https://crrev.com/a4afc11bf0f7caad494854d539c2e5bc11844496
Cr-Commit-Position: refs/heads/master@{#391244}
==========

[commit-bot: I haz the power, 2016-05-03 15:39:48]

Patchset 1 (id:??) landed as
https://crrev.com/a4afc11bf0f7caad494854d539c2e5bc11844496
Cr-Commit-Position: refs/heads/master@{#391244}