[wasm] Mark all 64-bit instructions as supported on 32-bit platforms.

src/compiler/int64-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/int64-lowering.h"
 #include "src/compiler/common-operator.h"
 #include "src/compiler/diamond.h"
 #include "src/compiler/graph.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/machine-operator.h"
@@ skipping 250 matching lines @@
       ReplaceNode(node, low_node, high_node);
       break;
     }
     case IrOpcode::kTruncateInt64ToInt32: {
       DCHECK(node->InputCount() == 1);
       Node* input = node->InputAt(0);
       ReplaceNode(node, GetReplacementLow(input), nullptr);
       node->NullAllInputs();
       break;
     }
-    // todo(ahaas): I added a list of missing instructions here to make merging
-    // easier when I do them one by one.
-    // kExprI64Add:
     case IrOpcode::kInt64Add: {
       DCHECK(node->InputCount() == 2);
 
       Node* right = node->InputAt(1);
       node->ReplaceInput(1, GetReplacementLow(right));
       node->AppendInput(zone(), GetReplacementHigh(right));
 
       Node* left = node->InputAt(0);
       node->ReplaceInput(0, GetReplacementLow(left));
       node->InsertInput(zone(), 1, GetReplacementHigh(left));
 
       NodeProperties::ChangeOp(node, machine()->Int32PairAdd());
       // We access the additional return values through projections.
       Node* low_node = graph()->NewNode(common()->Projection(0), node);
       Node* high_node = graph()->NewNode(common()->Projection(1), node);
       ReplaceNode(node, low_node, high_node);
       break;
     }
-
-    // kExprI64Sub:
     case IrOpcode::kInt64Sub: {
       DCHECK(node->InputCount() == 2);
 
       Node* right = node->InputAt(1);
       node->ReplaceInput(1, GetReplacementLow(right));
       node->AppendInput(zone(), GetReplacementHigh(right));
 
       Node* left = node->InputAt(0);
       node->ReplaceInput(0, GetReplacementLow(left));
       node->InsertInput(zone(), 1, GetReplacementHigh(left));
 
       NodeProperties::ChangeOp(node, machine()->Int32PairSub());
       // We access the additional return values through projections.
       Node* low_node = graph()->NewNode(common()->Projection(0), node);
       Node* high_node = graph()->NewNode(common()->Projection(1), node);
       ReplaceNode(node, low_node, high_node);
       break;
     }
-    // kExprI64Mul:
     case IrOpcode::kInt64Mul: {
       DCHECK(node->InputCount() == 2);
 
       Node* right = node->InputAt(1);
       node->ReplaceInput(1, GetReplacementLow(right));
       node->AppendInput(zone(), GetReplacementHigh(right));
 
       Node* left = node->InputAt(0);
       node->ReplaceInput(0, GetReplacementLow(left));
       node->InsertInput(zone(), 1, GetReplacementHigh(left));
 
       NodeProperties::ChangeOp(node, machine()->Int32PairMul());
       // We access the additional return values through projections.
       Node* low_node = graph()->NewNode(common()->Projection(0), node);
       Node* high_node = graph()->NewNode(common()->Projection(1), node);
       ReplaceNode(node, low_node, high_node);
       break;
     }
-    // kExprI64DivS:
-    // kExprI64DivU:
-    // kExprI64RemS:
-    // kExprI64RemU:
-    // kExprI64Ior:
     case IrOpcode::kWord64Or: {
       DCHECK(node->InputCount() == 2);
       Node* left = node->InputAt(0);
       Node* right = node->InputAt(1);
 
       Node* low_node =
           graph()->NewNode(machine()->Word32Or(), GetReplacementLow(left),
                            GetReplacementLow(right));
       Node* high_node =
           graph()->NewNode(machine()->Word32Or(), GetReplacementHigh(left),
                            GetReplacementHigh(right));
       ReplaceNode(node, low_node, high_node);
       break;
     }
-
-    // kExprI64Xor:
     case IrOpcode::kWord64Xor: {
       DCHECK(node->InputCount() == 2);
       Node* left = node->InputAt(0);
       Node* right = node->InputAt(1);
 
       Node* low_node =
           graph()->NewNode(machine()->Word32Xor(), GetReplacementLow(left),
                            GetReplacementLow(right));
       Node* high_node =
           graph()->NewNode(machine()->Word32Xor(), GetReplacementHigh(left),
                            GetReplacementHigh(right));
       ReplaceNode(node, low_node, high_node);
       break;
     }
-    // kExprI64Shl:
     case IrOpcode::kWord64Shl: {
       // TODO(turbofan): if the shift count >= 32, then we can set the low word
       // of the output to 0 and just calculate the high word.
       DCHECK(node->InputCount() == 2);
       Node* shift = node->InputAt(1);
       if (HasReplacementLow(shift)) {
         // We do not have to care about the high word replacement, because
         // the shift can only be between 0 and 63 anyways.
         node->ReplaceInput(1, GetReplacementLow(shift));
       }
 
       Node* value = node->InputAt(0);
       node->ReplaceInput(0, GetReplacementLow(value));
       node->InsertInput(zone(), 1, GetReplacementHigh(value));
 
       NodeProperties::ChangeOp(node, machine()->Word32PairShl());
       // We access the additional return values through projections.
       Node* low_node = graph()->NewNode(common()->Projection(0), node);
       Node* high_node = graph()->NewNode(common()->Projection(1), node);
       ReplaceNode(node, low_node, high_node);
       break;
     }
-    // kExprI64ShrU:
     case IrOpcode::kWord64Shr: {
       // TODO(turbofan): if the shift count >= 32, then we can set the low word
       // of the output to 0 and just calculate the high word.
       DCHECK(node->InputCount() == 2);
       Node* shift = node->InputAt(1);
       if (HasReplacementLow(shift)) {
         // We do not have to care about the high word replacement, because
         // the shift can only be between 0 and 63 anyways.
         node->ReplaceInput(1, GetReplacementLow(shift));
       }
 
       Node* value = node->InputAt(0);
       node->ReplaceInput(0, GetReplacementLow(value));
       node->InsertInput(zone(), 1, GetReplacementHigh(value));
 
       NodeProperties::ChangeOp(node, machine()->Word32PairShr());
       // We access the additional return values through projections.
       Node* low_node = graph()->NewNode(common()->Projection(0), node);
       Node* high_node = graph()->NewNode(common()->Projection(1), node);
       ReplaceNode(node, low_node, high_node);
       break;
     }
-    // kExprI64ShrS:
     case IrOpcode::kWord64Sar: {
       // TODO(turbofan): if the shift count >= 32, then we can set the low word
       // of the output to 0 and just calculate the high word.
       DCHECK(node->InputCount() == 2);
       Node* shift = node->InputAt(1);
       if (HasReplacementLow(shift)) {
         // We do not have to care about the high word replacement, because
         // the shift can only be between 0 and 63 anyways.
         node->ReplaceInput(1, GetReplacementLow(shift));
       }
 
       Node* value = node->InputAt(0);
       node->ReplaceInput(0, GetReplacementLow(value));
       node->InsertInput(zone(), 1, GetReplacementHigh(value));
 
       NodeProperties::ChangeOp(node, machine()->Word32PairSar());
       // We access the additional return values through projections.
       Node* low_node = graph()->NewNode(common()->Projection(0), node);
       Node* high_node = graph()->NewNode(common()->Projection(1), node);
       ReplaceNode(node, low_node, high_node);
       break;
     }
-    // kExprI64Eq:
     case IrOpcode::kWord64Equal: {
       DCHECK(node->InputCount() == 2);
       Node* left = node->InputAt(0);
       Node* right = node->InputAt(1);
 
       // TODO(wasm): Use explicit comparisons and && here?
       Node* replacement = graph()->NewNode(
           machine()->Word32Equal(),
           graph()->NewNode(
               machine()->Word32Or(),
               graph()->NewNode(machine()->Word32Xor(), GetReplacementLow(left),
                                GetReplacementLow(right)),
               graph()->NewNode(machine()->Word32Xor(), GetReplacementHigh(left),
                                GetReplacementHigh(right))),
           graph()->NewNode(common()->Int32Constant(0)));
 
       ReplaceNode(node, replacement, nullptr);
       break;
     }
-    // kExprI64LtS:
     case IrOpcode::kInt64LessThan: {
       LowerComparison(node, machine()->Int32LessThan(),
                       machine()->Uint32LessThan());
       break;
     }
     case IrOpcode::kInt64LessThanOrEqual: {
       LowerComparison(node, machine()->Int32LessThan(),
                       machine()->Uint32LessThanOrEqual());
       break;
     }
     case IrOpcode::kUint64LessThan: {
       LowerComparison(node, machine()->Uint32LessThan(),
                       machine()->Uint32LessThan());
       break;
     }
     case IrOpcode::kUint64LessThanOrEqual: {
       LowerComparison(node, machine()->Uint32LessThan(),
                       machine()->Uint32LessThanOrEqual());
       break;
     }
-
-    // kExprI64SConvertI32:
     case IrOpcode::kChangeInt32ToInt64: {
       DCHECK(node->InputCount() == 1);
       Node* input = node->InputAt(0);
       if (HasReplacementLow(input)) {
         input = GetReplacementLow(input);
       }
       // We use SAR to preserve the sign in the high word.
       ReplaceNode(
           node, input,
           graph()->NewNode(machine()->Word32Sar(), input,
                            graph()->NewNode(common()->Int32Constant(31))));
       node->NullAllInputs();
       break;
     }
-    // kExprI64UConvertI32: {
     case IrOpcode::kChangeUint32ToUint64: {
       DCHECK(node->InputCount() == 1);
       Node* input = node->InputAt(0);
       if (HasReplacementLow(input)) {
         input = GetReplacementLow(input);
       }
       ReplaceNode(node, input, graph()->NewNode(common()->Int32Constant(0)));
       node->NullAllInputs();
       break;
     }
-    // kExprF64ReinterpretI64:
     case IrOpcode::kBitcastInt64ToFloat64: {
       DCHECK(node->InputCount() == 1);
       Node* input = node->InputAt(0);
       Node* stack_slot = graph()->NewNode(
           machine()->StackSlot(MachineRepresentation::kWord64));
 
       Node* store_high_word = graph()->NewNode(
           machine()->Store(
               StoreRepresentation(MachineRepresentation::kWord32,
                                   WriteBarrierKind::kNoWriteBarrier)),
           stack_slot, graph()->NewNode(common()->Int32Constant(4)),
           GetReplacementHigh(input), graph()->start(), graph()->start());
 
       Node* store_low_word = graph()->NewNode(
           machine()->Store(
               StoreRepresentation(MachineRepresentation::kWord32,
                                   WriteBarrierKind::kNoWriteBarrier)),
           stack_slot, graph()->NewNode(common()->Int32Constant(0)),
           GetReplacementLow(input), store_high_word, graph()->start());
 
       Node* load =
           graph()->NewNode(machine()->Load(MachineType::Float64()), stack_slot,
                            graph()->NewNode(common()->Int32Constant(0)),
                            store_low_word, graph()->start());
 
       ReplaceNode(node, load, nullptr);
       break;
     }
-    // kExprI64ReinterpretF64:
     case IrOpcode::kBitcastFloat64ToInt64: {
       DCHECK(node->InputCount() == 1);
       Node* input = node->InputAt(0);
       if (HasReplacementLow(input)) {
         input = GetReplacementLow(input);
       }
       Node* stack_slot = graph()->NewNode(
           machine()->StackSlot(MachineRepresentation::kWord64));
       Node* store = graph()->NewNode(
           machine()->Store(
@@ skipping 115 matching lines @@
 
         Node* high_node = graph()->NewNode(
             machine()->Word32Or(),
             graph()->NewNode(machine()->Word32And(), rotate_high, bit_mask),
             graph()->NewNode(machine()->Word32And(), rotate_low, inv_mask));
 
         ReplaceNode(node, low_node, high_node);
       }
       break;
     }
-    // kExprI64Clz:
     case IrOpcode::kWord64Clz: {
       DCHECK(node->InputCount() == 1);
       Node* input = node->InputAt(0);
       Diamond d(
           graph(), common(),
           graph()->NewNode(machine()->Word32Equal(), GetReplacementHigh(input),
                            graph()->NewNode(common()->Int32Constant(0))));
 
       Node* low_node = d.Phi(
           MachineRepresentation::kWord32,
           graph()->NewNode(machine()->Int32Add(),
                            graph()->NewNode(machine()->Word32Clz(),
                                             GetReplacementLow(input)),
                            graph()->NewNode(common()->Int32Constant(32))),
           graph()->NewNode(machine()->Word32Clz(), GetReplacementHigh(input)));
       ReplaceNode(node, low_node, graph()->NewNode(common()->Int32Constant(0)));
       break;
     }
-    // kExprI64Ctz:
     case IrOpcode::kWord64Ctz: {
       DCHECK(node->InputCount() == 1);
       DCHECK(machine()->Word32Ctz().IsSupported());
       Node* input = node->InputAt(0);
       Diamond d(
           graph(), common(),
           graph()->NewNode(machine()->Word32Equal(), GetReplacementLow(input),
                            graph()->NewNode(common()->Int32Constant(0))));
       Node* low_node =
           d.Phi(MachineRepresentation::kWord32,
                 graph()->NewNode(machine()->Int32Add(),
                                  graph()->NewNode(machine()->Word32Ctz().op(),
                                                   GetReplacementHigh(input)),
                                  graph()->NewNode(common()->Int32Constant(32))),
                 graph()->NewNode(machine()->Word32Ctz().op(),
                                  GetReplacementLow(input)));
       ReplaceNode(node, low_node, graph()->NewNode(common()->Int32Constant(0)));
       break;
     }
-    // kExprI64Popcnt:
     case IrOpcode::kWord64Popcnt: {
       DCHECK(node->InputCount() == 1);
       Node* input = node->InputAt(0);
       // We assume that a Word64Popcnt node only has been created if
       // Word32Popcnt is actually supported.
       DCHECK(machine()->Word32Popcnt().IsSupported());
       ReplaceNode(node, graph()->NewNode(
                             machine()->Int32Add(),
                             graph()->NewNode(machine()->Word32Popcnt().op(),
                                              GetReplacementLow(input)),
@@ skipping 106 matching lines @@
                     common()->Phi(MachineRepresentation::kWord32, value_count),
                     value_count + 1, inputs_low, false),
                 graph()->NewNode(
                     common()->Phi(MachineRepresentation::kWord32, value_count),
                     value_count + 1, inputs_high, false));
   }
 }
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8