Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1941323002: [wasm] Mark all 64-bit instructions as supported on 32-bit platforms. (Closed)

Created:
4 years, 7 months ago by ahaas
Modified:
4 years, 7 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Mark all 64-bit instructions as supported on 32-bit platforms. Additionally I removed some stale comments. R=titzer@chromium.org Committed: https://crrev.com/b6db2255e6237b8af95fb199a63f2f1b977e505f Cr-Commit-Position: refs/heads/master@{#35976}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -188 lines) Patch
M src/compiler/int64-lowering.cc View 17 chunks +0 lines, -26 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 6 chunks +0 lines, -37 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/wasm/wasm-opcodes.cc View 1 1 chunk +0 lines, -60 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 30 chunks +21 lines, -35 lines 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 17 chunks +14 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ahaas
4 years, 7 months ago (2016-05-03 07:10:14 UTC) #1
titzer
lgtm other than removing WasmOpcodes::IsSupported() https://codereview.chromium.org/1941323002/diff/1/src/wasm/wasm-opcodes.cc File src/wasm/wasm-opcodes.cc (right): https://codereview.chromium.org/1941323002/diff/1/src/wasm/wasm-opcodes.cc#newcode103 src/wasm/wasm-opcodes.cc:103: bool WasmOpcodes::IsSupported(WasmOpcode opcode) { ...
4 years, 7 months ago (2016-05-03 08:20:15 UTC) #2
ahaas
https://codereview.chromium.org/1941323002/diff/1/src/wasm/wasm-opcodes.cc File src/wasm/wasm-opcodes.cc (right): https://codereview.chromium.org/1941323002/diff/1/src/wasm/wasm-opcodes.cc#newcode103 src/wasm/wasm-opcodes.cc:103: bool WasmOpcodes::IsSupported(WasmOpcode opcode) { On 2016/05/03 at 08:20:15, titzer ...
4 years, 7 months ago (2016-05-03 11:08:49 UTC) #3
titzer
On 2016/05/03 11:08:49, ahaas wrote: > https://codereview.chromium.org/1941323002/diff/1/src/wasm/wasm-opcodes.cc > File src/wasm/wasm-opcodes.cc (right): > > https://codereview.chromium.org/1941323002/diff/1/src/wasm/wasm-opcodes.cc#newcode103 > ...
4 years, 7 months ago (2016-05-03 11:09:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941323002/20001
4 years, 7 months ago (2016-05-03 11:10:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 11:46:43 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 11:48:14 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b6db2255e6237b8af95fb199a63f2f1b977e505f
Cr-Commit-Position: refs/heads/master@{#35976}

Powered by Google App Engine
This is Rietveld 408576698