Simplify logical iteration in SVGTextLayoutEngine

Simplify logical iteration in SVGTextLayoutEngine

By replacing m_logicalCharacterOffset == logicalTextNode->textLength()
by the corresponding metrics list equivalent, it becomes obvious that
we're just checking the same thing twice in succession. Remove the first
check and block of code.
Also reverse the test in the loop and refactor to avoid the 'continue'
when skipping whitespace.
The second part of the disjunction (w/ logicalMetrics.isEmpty()) does
not do anything useful, so is removed. This makes the condition match
what SVGTextLayoutAttributesBuilder does (which is the intention.)

BUG=607906
Committed: https://crrev.com/2f349013b11f8906316b41de2867f253a81ad147
Cr-Commit-Position: refs/heads/master@{#391281}

[fs, 2016-05-03 16:41:23]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, schenney@chromium.org

[Stephen Chennney, 2016-05-03 16:46:45]

lgtm

[fs, 2016-05-03 17:26:16]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-05-03 17:26:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1941303003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1941303003/1

[commit-bot: I haz the power, 2016-05-03 17:31:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-03 17:33:51]

Description was changed from

==========
Simplify logical iteration in SVGTextLayoutEngine

By replacing m_logicalCharacterOffset == logicalTextNode->textLength()
by the corresponding metrics list equivalent, it becomes obvious that
we're just checking the same thing twice in succession. Remove the first
check and block of code.
Also reverse the test in the loop and refactor to avoid the 'continue'
when skipping whitespace.
The second part of the disjunction (w/ logicalMetrics.isEmpty()) does
not do anything useful, so is removed. This makes the condition match
what SVGTextLayoutAttributesBuilder does (which is the intention.)

BUG=607906
==========

to

==========
Simplify logical iteration in SVGTextLayoutEngine

By replacing m_logicalCharacterOffset == logicalTextNode->textLength()
by the corresponding metrics list equivalent, it becomes obvious that
we're just checking the same thing twice in succession. Remove the first
check and block of code.
Also reverse the test in the loop and refactor to avoid the 'continue'
when skipping whitespace.
The second part of the disjunction (w/ logicalMetrics.isEmpty()) does
not do anything useful, so is removed. This makes the condition match
what SVGTextLayoutAttributesBuilder does (which is the intention.)

BUG=607906

Committed: https://crrev.com/2f349013b11f8906316b41de2867f253a81ad147
Cr-Commit-Position: refs/heads/master@{#391281}
==========

[commit-bot: I haz the power, 2016-05-03 17:33:52]

Patchset 1 (id:??) landed as
https://crrev.com/2f349013b11f8906316b41de2867f253a81ad147
Cr-Commit-Position: refs/heads/master@{#391281}