Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(147)

Issue 19413: Linux plugins WIP. (Closed)

Created:
10 years, 6 months ago by Evan Martin
Modified:
8 years, 3 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Get windowed plugins (Flash) limping along on Linux. We still crash when you navigate away from the page. (PS: the plan is to unfork the _gtk.cc file once it gets closer to what we want, so you don't need to look at that too closely. I just wanted to check in what I have since it's getting big.)

Patch Set 1 #

Patch Set 2 : missing files #

Patch Set 3 : hacked #

Patch Set 4 : omg it works #

Patch Set 5 : cleaned up #

Patch Set 6 : unforked header #

Patch Set 7 : done #

Total comments: 5

Patch Set 8 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+686 lines, -13 lines) Patch
M third_party/npapi/bindings/npapi.h View 3 4 5 6 7 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/glue/SConscript View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_host.cc View 3 4 5 6 2 chunks +24 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.h View 6 7 13 chunks +34 lines, -6 lines 0 comments Download
A webkit/glue/plugins/webplugin_delegate_impl_gtk.cc View 2 3 4 5 1 chunk +585 lines, -0 lines 0 comments Download
M webkit/glue/webplugin_delegate.h View 1 2 3 4 5 2 chunks +14 lines, -0 lines 0 comments Download
M webkit/glue/webplugin_impl.cc View 4 5 1 chunk +6 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 1 2 3 4 5 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Evan Martin
This is my current work on plugins. Jumping to a new branch to refactor the ...
10 years, 6 months ago (2009-01-28 01:43:12 UTC) #1
jam
we definitely don't want to fork webplugin_delegate_impl...
10 years, 6 months ago (2009-01-28 01:47:49 UTC) #2
Evan Martin
On 2009/01/28 01:47:49, John Abd-El-Malek wrote: > we definitely don't want to fork webplugin_delegate_impl... Yeah, ...
10 years, 6 months ago (2009-01-28 01:58:56 UTC) #3
Evan Martin
+awalker fyi This now successfully displays flash, though it's positioned slightly wrong and it crashes ...
10 years, 6 months ago (2009-01-29 23:27:11 UTC) #4
Evan Martin
After some other changes I've submitted, this diff now getting smaller. PS: To get the ...
10 years, 6 months ago (2009-01-30 02:06:23 UTC) #5
jam
It might be better to svn copy webplugin_delegate_impl* so that the patch shows the diff ...
10 years, 6 months ago (2009-01-30 03:39:18 UTC) #6
Amanda Walker
On 2009/01/30 03:39:18, John Abd-El-Malek wrote: > It might be better to svn copy webplugin_delegate_impl* ...
10 years, 6 months ago (2009-01-30 04:45:14 UTC) #7
Evan Martin
Ok, sorry for the repeated mails, but now I think it's ready for checkin pending ...
10 years, 6 months ago (2009-02-02 23:27:25 UTC) #8
Dean McNamee
Some minor comments. It's hard to review the forked file. Besides that, it's pretty slashy, ...
10 years, 6 months ago (2009-02-03 10:26:07 UTC) #9
Dean McNamee
Before you commit, make sure to update the description. I guess just try to mention ...
10 years, 6 months ago (2009-02-03 15:37:13 UTC) #10
Evan Martin
10 years, 6 months ago (2009-02-04 19:16:37 UTC) #11
ok, did what you asked, please look again

http://codereview.chromium.org/19413/diff/73/77
File webkit/glue/plugins/webplugin_delegate_impl.h (right):

http://codereview.chromium.org/19413/diff/73/77#newcode210
Line 210: gfx::NativeWindow parent_;
On 2009/02/03 10:26:08, Dean McNamee wrote:
> What's NativeView vs NativeWindow?

Conceptually, widget versus top-level window.
They're the same on Windows and effectively the same Linux, but different on
Mac.
This should've been NativeView, so good catch.

Powered by Google App Engine
This is Rietveld 408576698