Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1941133002: MD History: Use iron-scroll-threshold to determine when to load new data (Closed)

Created:
4 years, 7 months ago by tsergeant
Modified:
4 years, 7 months ago
Reviewers:
calamity, michaelpg
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pseudomaster
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Use iron-scroll-threshold to determine when to load new data This increases the threshold for new data to load from 10px to 500px, which is approximately 10-12 items worth of space from the bottom of the screen. BUG=425625 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ad9fefdfe4523e73514c40d7f233fd8b4b312806 Cr-Commit-Position: refs/heads/master@{#391752}

Patch Set 1 #

Patch Set 2 : Reformat #

Patch Set 3 : Remove from whitelist #

Patch Set 4 : Fix closure compile (how exciting!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/history_list.html View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_list.js View 1 2 3 2 chunks +8 lines, -14 lines 0 comments Download
M third_party/polymer/v1_0/find_unused_elements.py View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
tsergeant
4 years, 7 months ago (2016-05-03 00:16:13 UTC) #4
calamity
Cool bananas. lgtm
4 years, 7 months ago (2016-05-04 20:30:03 UTC) #5
tsergeant
+michaelpg@ for polymer_resources.grdp
4 years, 7 months ago (2016-05-04 20:37:47 UTC) #7
michaelpg
remove the TODO from find_unused_elements.sh
4 years, 7 months ago (2016-05-04 23:53:33 UTC) #8
michaelpg
On 2016/05/04 23:53:33, michaelpg wrote: > remove the TODO from find_unused_elements.sh find_unused_elements.py*
4 years, 7 months ago (2016-05-04 23:53:46 UTC) #9
tsergeant
On 2016/05/04 23:53:46, michaelpg wrote: > On 2016/05/04 23:53:33, michaelpg wrote: > > remove the ...
4 years, 7 months ago (2016-05-05 00:00:02 UTC) #11
michaelpg
sweet. lgtm
4 years, 7 months ago (2016-05-05 00:02:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941133002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941133002/80001
4 years, 7 months ago (2016-05-05 00:05:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/59)
4 years, 7 months ago (2016-05-05 00:24:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941133002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941133002/100001
4 years, 7 months ago (2016-05-05 00:37:38 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/222538)
4 years, 7 months ago (2016-05-05 01:29:51 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941133002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941133002/100001
4 years, 7 months ago (2016-05-05 03:27:50 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 7 months ago (2016-05-05 03:57:40 UTC) #25
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 04:00:06 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ad9fefdfe4523e73514c40d7f233fd8b4b312806
Cr-Commit-Position: refs/heads/master@{#391752}

Powered by Google App Engine
This is Rietveld 408576698