Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 1941083002: JobController 1: Adding a new class HttpStreamFactoryImpl::JobController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_request_unittest.cc ('k') | net/http/http_stream_factory_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_unittest.cc
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index 160cb8ddfd4679d55f99fe57beedce6bcaecdb44..198569b28ec57188ea68f1f608733afb6220b7b6 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -1469,9 +1469,6 @@ TEST_P(HttpStreamFactoryTest, RequestBidirectionalStreamImpl) {
EXPECT_EQ(0, GetSocketPoolGroupCount(session->GetSSLSocketPool(
HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
EXPECT_TRUE(waiter.used_proxy_info().is_direct());
- ASSERT_EQ(0u,
- static_cast<HttpStreamFactoryImpl*>(session->http_stream_factory())
- ->num_orphaned_jobs());
}
class HttpStreamFactoryBidirectionalQuicTest
@@ -1827,9 +1824,6 @@ TEST_P(HttpStreamFactoryTest, RequestBidirectionalStreamImplFailure) {
HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
EXPECT_EQ(0, GetSocketPoolGroupCount(session->GetSSLSocketPool(
HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
- ASSERT_EQ(0u,
- static_cast<HttpStreamFactoryImpl*>(session->http_stream_factory())
- ->num_orphaned_jobs());
}
// TODO(ricea): This test can be removed once the new WebSocket stack supports
@@ -2014,10 +2008,6 @@ TEST_P(HttpStreamFactoryTest, DISABLED_OrphanedWebSocketStream) {
EXPECT_EQ(1, GetSocketPoolGroupCount(
session->GetSSLSocketPool(HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
EXPECT_TRUE(waiter.used_proxy_info().is_direct());
-
- // Make sure there is no orphaned job. it is already canceled.
- ASSERT_EQ(0u, static_cast<HttpStreamFactoryImpl*>(
- session->http_stream_factory_for_websocket())->num_orphaned_jobs());
}
} // namespace
« no previous file with comments | « net/http/http_stream_factory_impl_request_unittest.cc ('k') | net/http/http_stream_factory_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698