JobController 1: Adding a new class HttpStreamFactoryImpl::JobController

net/http/http_stream_factory_impl_job_factory_impl.h

Index: net/http/http_stream_factory_impl_job_factory_impl.h
diff --git a/net/http/http_stream_factory_impl_job_factory_impl.h b/net/http/http_stream_factory_impl_job_factory_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..f951374409478ce8129579c5de63eebedb317bf0
--- /dev/null
+++ b/net/http/http_stream_factory_impl_job_factory_impl.h
@@ -0,0 +1,50 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_FACTORY_IMPL_H_
+#define NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_FACTORY_IMPL_H_
+
+#include <memory>
+
+#include "net/http/http_stream_factory_impl_job.h"
+#include "net/http/http_stream_factory_impl_job_controller.h"
+
+namespace net {
+
+class HttpNetworkSession;
+
+class HttpStreamFactoryImpl::JobFactoryImpl

[Ryan Hamilton, 2016/06/06 17:57:31]

I think you can just define the Impl in http_stream_factory.cc. You could also
add a static method:

HttpStreamFactoryImpl::DefaultFactory()

which could be called but HttpNetworkSession when constructing an
HttpStreamFactory.

[Zhongyi Shi, 2016/06/06 22:50:56]

You mean http_stream_factory.cc or http_stream_factory_impl.cc?

[Zhongyi Shi, 2016/06/08 04:30:25]

So we actually can't move the code to http_stream_factory_impl.cc the
request_unittest.cc also uses the JobFacotryImpl. But we will manage to move the
request_unittest in the Job Controller 2. Once we are in the Job Controller 2
and get rid of the JobFactoryImpl in request_unittest.cc, I will move this code
to http_stream_factory_impl.cc.

+    : public HttpStreamFactoryImpl::JobController::JobFactory {
+ public:
+  JobFactoryImpl();
+
+  ~JobFactoryImpl() override;
+
+  Job* CreateJob(HttpStreamFactoryImpl::Job::Delegate* delegate,
+                 JobType job_type,
+                 HttpNetworkSession* session,
+                 const HttpRequestInfo& request_info,
+                 RequestPriority priority,
+                 const SSLConfig& server_ssl_config,
+                 const SSLConfig& proxy_ssl_config,
+                 HostPortPair destination,
+                 GURL origin_url,
+                 NetLog* net_log) override;
+
+  Job* CreateJob(HttpStreamFactoryImpl::Job::Delegate* delegate,
+                 JobType job_type,
+                 HttpNetworkSession* session,
+                 const HttpRequestInfo& request_info,
+                 RequestPriority priority,
+                 const SSLConfig& server_ssl_config,
+                 const SSLConfig& proxy_ssl_config,
+                 HostPortPair destination,
+                 GURL origin_url,
+                 AlternativeService alternative_service,
+                 NetLog* net_log) override;
+};
+
+}  // namespace net
+
+#endif  // NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_FACTORY_IMPL_H_