JobController 1: Adding a new class HttpStreamFactoryImpl::JobController

net/http/http_stream_factory_impl_unittest.cc

Index: net/http/http_stream_factory_impl_unittest.cc
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index 6c7380dacbfd9bfd94a6bb18a464594300d2efae..0504326ac2b68ab0529e25915a8bc0cdd8fb0597 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -1471,9 +1471,6 @@ TEST_P(HttpStreamFactoryTest, RequestBidirectionalStreamImpl) {
   EXPECT_EQ(0, GetSocketPoolGroupCount(session->GetSSLSocketPool(
                    HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
   EXPECT_TRUE(waiter.used_proxy_info().is_direct());
-  ASSERT_EQ(0u,
-            static_cast<HttpStreamFactoryImpl*>(session->http_stream_factory())
-                ->num_orphaned_jobs());

[Randy Smith (Not in Mondays), 2016/05/16 22:01:10]

Is this a decrease in test coverage?  I didn't see a replacement for this check
in the other unit test.

[Randy Smith (Not in Mondays), 2016/05/23 21:39:26]

Ping?

[Zhongyi Shi, 2016/05/25 00:48:53]

Yeah, we don't have any replacement here. The old code adds all the orphaned
jobs to http_stream_factory, and deletes them. However, in the new code, we hide
this in JobController. Since this is a FacotryTest, I won't be too worried on
that. 

 }
 
 class HttpStreamFactoryBidirectionalQuicTest
@@ -1812,9 +1809,6 @@ TEST_P(HttpStreamFactoryTest, RequestBidirectionalStreamImplFailure) {
                    HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
   EXPECT_EQ(0, GetSocketPoolGroupCount(session->GetSSLSocketPool(
                    HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
-  ASSERT_EQ(0u,
-            static_cast<HttpStreamFactoryImpl*>(session->http_stream_factory())
-                ->num_orphaned_jobs());
 }
 
 // TODO(ricea): This test can be removed once the new WebSocket stack supports
@@ -2000,10 +1994,6 @@ TEST_P(HttpStreamFactoryTest, DISABLED_OrphanedWebSocketStream) {
   EXPECT_EQ(1, GetSocketPoolGroupCount(
       session->GetSSLSocketPool(HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
   EXPECT_TRUE(waiter.used_proxy_info().is_direct());
-
-  // Make sure there is no orphaned job. it is already canceled.
-  ASSERT_EQ(0u, static_cast<HttpStreamFactoryImpl*>(
-      session->http_stream_factory_for_websocket())->num_orphaned_jobs());
 }
 
 }  // namespace