Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: net/cert/cert_verify_proc_unittest.cc

Issue 1941083002: JobController 1: Adding a new class HttpStreamFactoryImpl::JobController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment/naming fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_stream_factory.h » ('j') | net/http/http_stream_factory_impl_job.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/cert_verify_proc_unittest.cc
diff --git a/net/cert/cert_verify_proc_unittest.cc b/net/cert/cert_verify_proc_unittest.cc
index 3a9614fa9a5370149b21b31b7474a35a765c55be..3c6e345f47ee3aa5b7918d1ca0da279685282623 100644
--- a/net/cert/cert_verify_proc_unittest.cc
+++ b/net/cert/cert_verify_proc_unittest.cc
@@ -663,7 +663,8 @@ TEST_F(CertVerifyProcTest, TestHasTooLongValidity) {
}
}
-TEST_F(CertVerifyProcTest, TestKnownRoot) {
+// TODO(crbug.com/610546): Fix and re-enable this test.
+TEST_F(CertVerifyProcTest, DISABLED_TestKnownRoot) {
Randy Smith (Not in Mondays) 2016/05/16 22:01:10 Why is this test being disabled as part of this CL
Zhongyi Shi 2016/05/16 23:08:53 It's just a manually temp fix. It's in origin/mast
if (!SupportsDetectingKnownRoots()) {
LOG(INFO) << "Skipping this test on this platform.";
return;
@@ -691,7 +692,8 @@ TEST_F(CertVerifyProcTest, TestKnownRoot) {
EXPECT_TRUE(verify_result.is_issued_by_known_root);
}
-TEST_F(CertVerifyProcTest, PublicKeyHashes) {
+// TODO(crbug.com/610546): Fix and re-enable this test.
+TEST_F(CertVerifyProcTest, DISABLED_PublicKeyHashes) {
if (!SupportsReturningVerifiedChain()) {
LOG(INFO) << "Skipping this test in this platform.";
return;
« no previous file with comments | « no previous file | net/http/http_stream_factory.h » ('j') | net/http/http_stream_factory_impl_job.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698