JobController 1: Adding a new class HttpStreamFactoryImpl::JobController

net/http/http_stream_factory_impl_job_factory_impl.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_FACTORY_IMPL_H_
+#define NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_FACTORY_IMPL_H_
+
+#include <memory>
+
+#include "net/http/http_stream_factory_impl_job.h"
+#include "net/http/http_stream_factory_impl_job_controller.h"
+
+namespace net {
+
+class HttpNetworkSession;
+
+class HttpStreamFactoryImpl::JobFactoryImpl

[Randy Smith (Not in Mondays), 2016/06/09 14:26:54]

Suggestion: Why not have HttpStreamFactoryImpl derive from JobFactory and
implement these methods?  These are pretty trivial, I'm not sure we need another
class/file set for them.

(This would probably require JobFactory to not be a nested class of
JobController, but three levels of nested classes is getting a bit extreme
anyway.)

+    : public HttpStreamFactoryImpl::JobController::JobFactory {
+ public:
+  JobFactoryImpl();
+
+  ~JobFactoryImpl() override;
+
+  Job* CreateJob(HttpStreamFactoryImpl::Job::Delegate* delegate,
+                 JobType job_type,
+                 HttpNetworkSession* session,
+                 const HttpRequestInfo& request_info,
+                 RequestPriority priority,
+                 const SSLConfig& server_ssl_config,
+                 const SSLConfig& proxy_ssl_config,
+                 HostPortPair destination,
+                 GURL origin_url,
+                 NetLog* net_log) override;
+
+  Job* CreateJob(HttpStreamFactoryImpl::Job::Delegate* delegate,
+                 JobType job_type,
+                 HttpNetworkSession* session,
+                 const HttpRequestInfo& request_info,
+                 RequestPriority priority,
+                 const SSLConfig& server_ssl_config,
+                 const SSLConfig& proxy_ssl_config,
+                 HostPortPair destination,
+                 GURL origin_url,
+                 AlternativeService alternative_service,
+                 NetLog* net_log) override;
+};
+
+}  // namespace net
+
+#endif  // NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_FACTORY_IMPL_H_