JobController 1: Adding a new class HttpStreamFactoryImpl::JobController

net/http/http_stream_factory_impl_job_factory.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_FACTORY_H_
+#define NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_FACTORY_H_
+
+#include <memory>
+
+#include "net/http/http_stream_factory_impl.h"
+#include "net/http/http_stream_factory_impl_job.h"
+
+namespace net {
+
+class HttpNetworkSession;
+
+class HttpStreamFactoryImpl::JobFactory {

[Ryan Hamilton, 2016/06/03 00:11:24]

As discussed offline, I think I would make this an interface in JobController.
The HttpStreamFactoryImpl can create a private JobFactory subclass to return
HttpStreamFactoryImpl::Jobs and the tests can return MockJobs (or the like)

[Zhongyi Shi, 2016/06/03 23:09:21]

Done. Yay!!

+ public:
+  JobFactory();
+
+  virtual ~JobFactory();
+
+  virtual Job* CreateJob(HttpStreamFactoryImpl::Job::Delegate* delegate,
+                         JobType job_type,
+                         HttpNetworkSession* session,
+                         const HttpRequestInfo& request_info,
+                         RequestPriority priority,
+                         const SSLConfig& server_ssl_config,
+                         const SSLConfig& proxy_ssl_config,
+                         HostPortPair destination,
+                         GURL origin_url,
+                         NetLog* net_log);
+
+  virtual Job* CreateJob(HttpStreamFactoryImpl::Job::Delegate* delegate,
+                         JobType job_type,
+                         HttpNetworkSession* session,
+                         const HttpRequestInfo& request_info,
+                         RequestPriority priority,
+                         const SSLConfig& server_ssl_config,
+                         const SSLConfig& proxy_ssl_config,
+                         HostPortPair destination,
+                         GURL origin_url,
+                         AlternativeService alternative_service,
+                         NetLog* net_log);
+};
+
+}  // namespace net
+
+#endif  // NET_HTTP_HTTP_STREAM_FACTORY_IMPL_JOB_FACTORY_H_