Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1941033002: Enable check-ipc for chromeos and chromecast. (Closed)

Created:
4 years, 7 months ago by Dmitry Skiba
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check IPC messages for banned types on ChromeOS. This change enables check-ipc option for find-bad-constructs Clang plugin on ChromeOS (in addition to Linux and Android). With that option Clang plugin will check that the following types are not used in IPC messages: 1. Types: long / unsigned long (but not typedefs to) 2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, size_t, rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, time_t, suseconds_t (including typedefs to) 3. Any template referencing the above (e.g. std::vector<size_t>) BUG=581409 Committed: https://crrev.com/5bce05dfcc21c872c5ae4909ccb35780360dfc66 Cr-Commit-Position: refs/heads/master@{#391328}

Patch Set 1 #

Patch Set 2 : Exclude chromecast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/config/clang/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Dmitry Skiba
4 years, 7 months ago (2016-05-03 19:26:55 UTC) #4
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-03 19:28:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941033002/20001
4 years, 7 months ago (2016-05-03 19:30:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 19:35:38 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 19:36:42 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5bce05dfcc21c872c5ae4909ccb35780360dfc66
Cr-Commit-Position: refs/heads/master@{#391328}

Powered by Google App Engine
This is Rietveld 408576698