Issue 194101: Update the sadtab and throbbers to use the helpers for fetching strings/image...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194101: Update the sadtab and throbbers to use the helpers for fetching strings/image... (Closed)

Created:
11 years, 3 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Update the sadtab and throbbers to use the helpers for fetching strings/images from pak file. Use the images directly from the pak files instead of having extra copies in the bundle. TEST=sad tab page still works and has all images. throbbers still work. the app should no longer carry the sadtab and throbber images directly. BUG=20230 BUG=21076 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26106

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -14 lines)			Patch
M	chrome/browser/cocoa/sad_tab_view.mm	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/cocoa/tab_strip_controller.mm	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages