Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 194101: Update the sadtab and throbbers to use the helpers for fetching strings/image... (Closed)

Created:
11 years, 3 months ago by TVL
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)
Visibility:
Public.

Description

Update the sadtab and throbbers to use the helpers for fetching strings/images from pak file. Use the images directly from the pak files instead of having extra copies in the bundle. TEST=sad tab page still works and has all images. throbbers still work. the app should no longer carry the sadtab and throbber images directly. BUG=20230 BUG=21076 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M chrome/browser/cocoa/sad_tab_view.mm View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller.mm View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
TVL
11 years, 3 months ago (2009-09-14 14:38:24 UTC) #1
pink (ping after 24hrs)
lgtm
11 years, 3 months ago (2009-09-14 14:43:13 UTC) #2
Avi (use Gerrit)
11 years, 3 months ago (2009-09-14 14:48:46 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698