Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1941003002: Turn on MojoChannel (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on MojoChannel Removes --enable-mojo-channel and the MojoChannel field trial. Turns on MojoChannel permanently. BUG=595082 Committed: https://crrev.com/1e213694248b28e9f15be63c006009e249063808 Cr-Commit-Position: refs/heads/master@{#391029}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -87 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +12 lines, -34 lines 0 comments Download
M content/public/common/mojo_channel_switches.h View 1 chunk +0 lines, -7 lines 2 comments Download
M content/public/common/mojo_channel_switches.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +2 lines, -6 lines 2 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 2 chunks +1 line, -9 lines 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ken Rockot(use gerrit already)
4 years, 7 months ago (2016-05-02 18:17:41 UTC) #2
jam
lgtm https://codereview.chromium.org/1941003002/diff/1/content/public/common/mojo_channel_switches.h File content/public/common/mojo_channel_switches.h (right): https://codereview.chromium.org/1941003002/diff/1/content/public/common/mojo_channel_switches.h#newcode12 content/public/common/mojo_channel_switches.h:12: CONTENT_EXPORT extern const char kMojoChannelToken[]; (not for this ...
4 years, 7 months ago (2016-05-02 19:09:00 UTC) #3
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1941003002/diff/1/content/public/common/mojo_channel_switches.h File content/public/common/mojo_channel_switches.h (right): https://codereview.chromium.org/1941003002/diff/1/content/public/common/mojo_channel_switches.h#newcode12 content/public/common/mojo_channel_switches.h:12: CONTENT_EXPORT extern const char kMojoChannelToken[]; On 2016/05/02 at 19:09:00, ...
4 years, 7 months ago (2016-05-02 19:33:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1941003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1941003002/1
4 years, 7 months ago (2016-05-02 19:33:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 19:37:23 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1e213694248b28e9f15be63c006009e249063808 Cr-Commit-Position: refs/heads/master@{#391029}
4 years, 7 months ago (2016-05-02 19:39:36 UTC) #9
Ken Rockot(use gerrit already)
4 years, 7 months ago (2016-05-03 13:30:00 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1946573002/ by rockot@chromium.org.

The reason for reverting is: Speculative revert for
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2....

Powered by Google App Engine
This is Rietveld 408576698