Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js

Issue 1940993002: DevTools: simplify Service Workers panel UI, remove non-actionable data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment addressed. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
index 0bd9dc5d17d6f0783d4fb5403bf8cdc8ea08a44d..f9fccf1afdf10f56b52a9c3173944333198e06cf 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
@@ -48,8 +48,8 @@ WebInspector.ResourcesPanel = function()
this.setDefaultFocusedElement(this._sidebarTree.element);
this._applicationTreeElement = this._addSidebarSection(WebInspector.UIString("Application"));
- var manifestTreeElement = new WebInspector.AppManifestTreeElement(this);
- this._applicationTreeElement.appendChild(manifestTreeElement);
+ this._manifestTreeElement = new WebInspector.AppManifestTreeElement(this);
+ this._applicationTreeElement.appendChild(this._manifestTreeElement);
var storageTreeElement = this._addSidebarSection(WebInspector.UIString("Storage"));
this.localStorageListTreeElement = new WebInspector.StorageCategoryTreeElement(this, WebInspector.UIString("Local Storage"), "LocalStorage", ["domstorage-storage-tree-item", "local-storage"]);
@@ -114,12 +114,8 @@ WebInspector.ResourcesPanel.prototype = {
wasShown: function()
{
- if (!this._sidebarTree.selectedTreeElement) {
- if (this.serviceWorkersTreeElement)
- this.serviceWorkersTreeElement.select();
- else
- this.localStorageListTreeElement.select();
- }
+ if (!this._sidebarTree.selectedTreeElement)
+ this._manifestTreeElement.select();
},
/**
@@ -134,7 +130,7 @@ WebInspector.ResourcesPanel.prototype = {
if (target.serviceWorkerManager) {
this.serviceWorkersTreeElement = new WebInspector.ServiceWorkersTreeElement(this);
- this._applicationTreeElement.insertChild(this.serviceWorkersTreeElement, 0);
+ this._applicationTreeElement.appendChild(this.serviceWorkersTreeElement);
}
this._databaseModel = WebInspector.DatabaseModel.fromTarget(target);

Powered by Google App Engine
This is Rietveld 408576698