Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view.html

Issue 1940993002: DevTools: simplify Service Workers panel UI, remove non-actionable data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment addressed. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view.html b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view.html
index 3ec554f78cda4a4cc6da9479554a69d2c6f2488c..23f1c5f0ecc5606cb054112add902646b79bdb01 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view.html
@@ -10,8 +10,8 @@ function test()
var scriptURL = "http://127.0.0.1:8000/inspector/service-workers/resources/service-worker-empty.js";
var scope1 = "http://127.0.0.1:8000/inspector/service-workers/resources/scope1/";
var scope2 = "http://127.0.0.1:8000/inspector/service-workers/resources/scope2/";
- var scopes = [scope1, scope2];
var step = 0;
+ WebInspector.ServiceWorkersView._noThrottle = true;
InspectorTest.addSniffer(WebInspector.ServiceWorkersView.prototype, "_updateRegistration", updateRegistration, true);
function updateRegistration(registration)
@@ -19,17 +19,17 @@ function test()
for (var version of registration.versions.values()) {
if (step == 0 && registration.scopeURL == scope1 && version.isActivated() && version.isRunning()) {
++step;
- InspectorTest.addResults(InspectorTest.dumpServiceWorkersView(scopes));
+ InspectorTest.addResult(InspectorTest.dumpServiceWorkersView());
InspectorTest.addResult("Register ServiceWorker for scope2");
InspectorTest.registerServiceWorker(scriptURL, scope2);
} else if (step == 1 && registration.scopeURL == scope2 && version.isActivated() && version.isRunning()) {
++step;
- InspectorTest.addResults(InspectorTest.dumpServiceWorkersView(scopes));
+ InspectorTest.addResult(InspectorTest.dumpServiceWorkersView());
InspectorTest.addResult("Unegister ServiceWorker for scope1");
InspectorTest.unregisterServiceWorker(scope1);
} else if (step == 2 && registration.scopeURL == scope1 && version.isRedundant() && version.isRunning()) {
++step;
- InspectorTest.addResults(InspectorTest.dumpServiceWorkersView(scopes));
+ InspectorTest.addResult(InspectorTest.dumpServiceWorkersView());
InspectorTest.addResult("Unegister ServiceWorker for scope1");
InspectorTest.unregisterServiceWorker(scope2);
} else if (step == 3 && registration.scopeURL == scope2 && version.isRedundant()) {

Powered by Google App Engine
This is Rietveld 408576698